Make the PrettyFormatter work by reverting to all-steps-first execution #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To aid testing, make it possible to inject a glue when creating a Runtime. Also add a test specify that a CucumberException is thrown if no backends are found (or an emtpy collection of backends is injected).
Adjust the number of . separating the step text from the step result, so that the results are aligned.
The main issue is that the JUnitFormatter does not handle failures in the before and after hooks properly. To add flexibility the tests also specify that the JUnitFormatter should handle both all-steps-first execution and one-step-at-the-time execution.
Change the JUnitFormatter to handle failures in the before and after hooks properly. Also change the JUnitFormatter to handle both all-steps-first execution and one-step-at-the-time execution.
To fix the missmatch between the PrettyFormatter from the Gherkin library and Cucumber-JVM, by reverting the scenario execution to all-steps-first execution as in Cucumber-JVM 1.1.2. This is possible since the JSONFormatter in the Gherkin library in Gherkin 2.12.0 supports all-steps-first execution.
brasmusson
added a commit
to brasmusson/cucumber-jvm
that referenced
this pull request
Jul 14, 2013
Verify that the changes in PR cucumber#557 indeed fixes cucumber#491 and the other reports of that the PrettyFormatter is broken.
|
LGTM! |
|
@brasmusson thanks! Can you also make sure to update History.md for every issue/PR you close? |
|
@aslakhellesoy The PR:s I got covered, but I make sure to update History.md with issue #491 which I closed. |
|
@aslakhellesoy #491 added to History.md in 4439178 (when #544 was merged) |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve the mismatch between the PrettyFormatter in the Gherkin library and Cucumber-JVM, by reverting to the all-steps-first-execution which was used in Cucumber-JVM version 1.1.2.
This is safe since the JSONFormatter issues triggering the change to one-step-at-the-time execution in Cucumber-JVM version 1.1.3 (#426) has been resolved by cucumber/gherkin#216 in Gherkin 2.12.0. The JSONFormatterTest added in #426 verifies this.