Convert to use the Gherkin compiler and Pickles #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Cucumber::Core::Ast is removed. * Cucumber::Core::Case/Step need to own all data necessary for execution, there is not #source which refers to any Ast data. This also mean that some classes Tag, Location, DataTable, DocString etc are moved the the Cucumber::Core::Ast to Cucumber::Core::Test. * The class Cucumber::Core::Compiler still exists, but it creates Test::Cases/Steps from Pickles (instead of from the Ast). * The locations of Test::Case/Step mimics the locations of the Pickle(/Step), so a Case/Step from an Scenario Outline will have two lines in the location. * The LocationsFilter can only match the lines of the Test::Case/Step, which is more limited than previously when the lines from all Ast object contained in the Test::Case/Step#source could be matched.
This was referenced Jul 16, 2018
This was referenced Jul 24, 2018
brasmusson
added a commit
that referenced
this pull request
Jul 26, 2018
Also update the gemspec and Changelog.md.
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Jan 20, 2019
## [4.0.0](cucumber/cucumber-ruby-core@v3.2.0...v4.0.0) ### Changed * Update to use Gherkin v6 ([#158](cucumber/cucumber-ruby-core#158) @brasmusson) * Let Scenarios with no Steps get the result status Undefined ([#157](cucumber/cucumber-ruby-core#157) @brasmusson) * Convert to use the Gherkin compiler and Pickles ([#156](cucumber/cucumber-ruby-core#156) @brasmusson) ### Added * N/A ### Fixed * N/A ### Removed * Remove the support for old style tag expressions ([#159](cucumber/cucumber-ruby-core#159) @brasmusson)
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Convert to use the Gherkin compiler and Pickles
Details
Motivation and Context
Use the full capabilities of the Gherkin library, consistency with other Cucumber implementations, and
as a preparation for moving to Gherkin v6 (which has the new
Rulekeyword).How Has This Been Tested?
The automated test suite has been updated to verify the new behavior.
These changes has been tested together with the corresponding changes in Cucumber-Ruby.
Types of changes
Checklist: