Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to the move of Location to Cucumber::Core::Test #14

Merged
merged 2 commits into from
Jul 26, 2018

Conversation

brasmusson
Copy link
Contributor

As consequences of the changes in cucumber/cucumber-ruby-core#156:

  • the references to the Location class have to be updated (changed from Cucumber::Core::Ast::Location to Cucumber::Core::Test::Location).
  • the source parameter has to be removed when creating Hooks.

* Pass the registry all the way down to the step definitions.
* Move the class StepArgument from Cucumber-Ruby and update it to match
  the expectations of Cucumber-Ruby when using cucumber-expressions.
@brasmusson brasmusson merged commit 51ff015 into master Jul 26, 2018
brasmusson added a commit that referenced this pull request Jul 26, 2018
Also update Changelog.md, cucumber-wire.gemspec and .travis.yml.
@brasmusson brasmusson deleted the use-pickles branch July 26, 2018 13:29
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Jan 20, 2019
## [1.0.0](cucumber/cucumber-ruby-wire@v0.0.1...v1.0.0)

### Added

* Added this CHANGELOG.md file per [cucumber/cucumber
  #251](cucumber/common#251)
  ([#13](cucumber/cucumber-ruby-wire#13)
  [jaysonesmith](https://github.com/jaysonesmith))

### Changed

* Changes to work with a modern Cucumber-Ruby
  ([#14](cucumber/cucumber-ruby-wire#14)
  [brasmusson](https://github.com/brasmusson))
* Adapt to the move of Location to Cucumber::Core::Test
  ([#14](cucumber/cucumber-ruby-wire#14)
  [brasmusson](https://github.com/brasmusson))

<!-- Contributors -->
[brasmusson]:   https://github.com/brasmusson
[jaysonesmith]: https://github.com/jaysonesmith
[junaruga]:     https://github.com/junaruga
[mattwynne]:    https://github.com/mattwynne
[olleolleolle]: https://github.com/olleolleolle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant