-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Reverse the order of after hooks when applied to a test case.
Add a feature documenting the order after hooks should be executed. See: https://github.com/cucumber/cucumber/wiki/Hooks#scenario-hooks cc. @mattwynne
- Loading branch information
Showing
2 changed files
with
25 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24ea079
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well spotted @tooky. I have deja vu about this but I can't find an existing ticket. Glad it's resolved anyway. Don't forget to update
History.md
too.24ea079
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattwynne Yep, it was fixed once in the core: cucumber/cucumber-ruby-core#64. I remember playing with several hooks of the same type when working on formatter issues (like #746 - which the screen shots shows), but in the end I did not leave a feature or spec using more than one hook of each type for those formatter changes.
24ea079
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah that explains it. And when we moved the hooks out of the core we lost that detail. Thanks @brasmusson.
24ea079
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @brasmusson, I had a feeling it might have been in the core.