Fix the HTML formatters handling of output from hooks #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
brasmusson
referenced
this pull request
Mar 24, 2015
Add a feature documenting the order after hooks should be executed. See: https://github.com/cucumber/cucumber/wiki/Hooks#scenario-hooks cc. @mattwynne
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v1.3.x the HTML formatter delays the output from the Before hook until after the first step, and delays the output from the After hooks to until after the first step in the next Scenario:
In v2.0.0.beta.1 the output from AfterStep and After hooks was not printed at all. With the changes in #732 and #738, the handling of hook output was brought up to the same behaviour as v1.3.x. This PR fixes the remaining issues with respect to the HTML formatters handling of hook output, resulting in this behaviour:
Fixes #731.