Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rubocop offenses 1021 003 #1107

Merged
merged 3 commits into from
Apr 13, 2017
Merged

Fix rubocop offenses 1021 003 #1107

merged 3 commits into from
Apr 13, 2017

Conversation

bv
Copy link
Member

@bv bv commented Apr 12, 2017

Summary

Several fixes have been made for some of the RuboCop offenses reported.

Details

There are rubocop offenses, which has been fixed:
Style/TrailingCommaInLiteral
Style/SpaceBeforeFirstArg
Style/ParenthesesAroundCondition

Motivation and Context

There is bunch of exceptions for the code styling tool of RoboCop to be fixed.
Here is the main issue: #1021

How Has This Been Tested?

bundle exec rake produces no test failures
There build configuration on Travis passes green: https://travis-ci.org/bv/cucumber-ruby-bv/builds/218226436

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@nodo nodo merged commit 41a9043 into cucumber:master Apr 13, 2017
@nodo
Copy link
Member

nodo commented Apr 13, 2017

Great job @bv ! Thanks a lot 👍

@mattwynne
Copy link
Member

Thanks @bv, and thanks @nodo for reviewing and merging so quickly.

@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants