Fix rubocop offenses 1021 003

.rubocop_todo.yml

@@ -752,13 +752,6 @@ Style/OpMethod:
 Style/ParallelAssignment:
   Enabled: false
 
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: AllowSafeAssignment.
-Style/ParenthesesAroundCondition:
-  Exclude:
-    - 'lib/cucumber/multiline_argument/data_table.rb'
-
 # Offense count: 225
 # Cop supports --auto-correct.
 # Configuration parameters: PreferredDelimiters.
@@ -986,13 +979,6 @@ Style/SpaceBeforeComma:
   Exclude:
     - 'lib/cucumber/term/ansicolor.rb'
 
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: AllowForAlignment.
-Style/SpaceBeforeFirstArg:
-  Exclude:
-    - 'spec/cucumber/rb_support/rb_step_definition_spec.rb'
-
 # Offense count: 255
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
@@ -1077,18 +1063,6 @@ Style/SymbolProc:
 Style/TrailingBlankLines:
   Enabled: false
 
-# Offense count: 43
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyleForMultiline, SupportedStyles.
-# SupportedStyles: comma, consistent_comma, no_comma
-Style/TrailingCommaInLiteral:
-  Exclude:
-    - 'lib/cucumber/cli/options.rb'
-    - 'lib/cucumber/term/ansicolor.rb'
-    - 'spec/cucumber/file_specs_spec.rb'
-    - 'spec/cucumber/filters/tag_limits/verifier_spec.rb'
-    - 'spec/cucumber/formatter/legacy_api/adapter_spec.rb'
-
 # Offense count: 18
 # Cop supports --auto-correct.
 # Reviewed: in pretty_spec.rb, progress_spec.rb offences look false,

lib/cucumber/cli/options.rb

@@ -316,7 +316,7 @@ def banner
           'cucumber examples/i18n/en/features',
           'cucumber @rerun.txt (See --format rerun)',
           'cucumber examples/i18n/it/features/somma.feature:6:98:113',
-          'cucumber -s -i http://rubyurl.com/eeCl', '', '',
+          'cucumber -s -i http://rubyurl.com/eeCl', '', ''
         ].join("\n")
       end
 

lib/cucumber/multiline_argument/data_table.rb

@@ -585,7 +585,7 @@ def pad_and_match(a_cell_matrix, other_cell_matrix) #:nodoc:
 
         header_values.each_with_index do |v, i|
           mapped_index = unmatched_cols.index{|unmapped_col| unmapped_col.first == v}
-          if (mapped_index)
+          if mapped_index
             matched_cols << unmatched_cols.delete_at(mapped_index)
           else
             mark_as_missing(cols[i])

lib/cucumber/term/ansicolor.rb

@@ -33,7 +33,7 @@ module ANSIColor
         [ :on_blue      ,  44 ],
         [ :on_magenta   ,  45 ],
         [ :on_cyan      ,  46 ],
-        [ :on_white     ,  47 ],
+        [ :on_white     ,  47 ]
       ]
 
       ATTRIBUTE_NAMES = ATTRIBUTES.transpose.first

spec/cucumber/file_specs_spec.rb

@@ -15,15 +15,15 @@ module Cucumber
         Cucumber::Core::Ast::Location.new('features/foo.feature', 3),
         Cucumber::Core::Ast::Location.new('features/bar.feature', 4),
         Cucumber::Core::Ast::Location.new('features/bar.feature', 5),
-        Cucumber::Core::Ast::Location.new('features/bar.feature', 6),
+        Cucumber::Core::Ast::Location.new('features/bar.feature', 6)
       ]
     end
 
     it 'parses file names from multiple file specs' do
       expect(files.length).to eq 2
       expect(files).to eq [
         'features/foo.feature',
-        'features/bar.feature',
+        'features/bar.feature'
       ]
     end
 
@@ -42,7 +42,7 @@ module Cucumber
       it 'returns a wildcard location for that file' do
         expect(locations).to eq [
           Cucumber::Core::Ast::Location.new('features/foo.feature'),
-          Cucumber::Core::Ast::Location.new('features/bar.feature', 34),
+          Cucumber::Core::Ast::Location.new('features/bar.feature', 34)
         ]
       end
     end
@@ -53,7 +53,7 @@ module Cucumber
       it 'returns locations in the order specified' do
         expect(locations).to eq [
           Cucumber::Core::Ast::Location.new('features/foo.feature', 10),
-          Cucumber::Core::Ast::Location.new('features/foo.feature', 1),
+          Cucumber::Core::Ast::Location.new('features/foo.feature', 1)
         ]
       end
     end

spec/cucumber/filters/tag_limits/verifier_spec.rb

@@ -16,7 +16,7 @@
       let(:locations) do
         [
           double(:location, to_s: 'path/to/some.feature:3'),
-          double(:location, to_s: 'path/to/some/other.feature:8'),
+          double(:location, to_s: 'path/to/some/other.feature:8')
         ]
       end