Support ruby 2.2 for 1.3.x #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby2.2 doesn't contain it as default.
``` diff -No such file or directory - features. Please create a features directory to get started. (Errno::ENOENT) +No such file or directory @ rb_sysopen - features. Please create a features directory to get started. (Errno::ENOENT) ```
The behavor of method as default argument has been changed in Ruby2.2. see: https://bugs.ruby-lang.org/issues/10314
|
Thank you! Ref #781. |
|
Could you guys release new 1.3.x with Ruby 2.2 support? Are there any blockers? |
|
Christmas is my blocker, personally. |
|
@rwz v1.3.18, released last night, contains this patch. |
|
@tooky can you pull this into master too? |
|
@mattwynne yes I'll get it sorted when I get a minute. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.