Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tune for lightgbm not working when sample_size = tune() #22

Open
Athospd opened this issue Aug 2, 2020 · 3 comments · Fixed by #40
Open

tune for lightgbm not working when sample_size = tune() #22

Athospd opened this issue Aug 2, 2020 · 3 comments · Fixed by #40
Labels
bug Something isn't working

Comments

@Athospd
Copy link
Member

Athospd commented Aug 2, 2020

tune_grid() not working when sample_size = tune().
@Athospd Athospd added the bug Something isn't working label Aug 2, 2020
Athospd added a commit that referenced this issue Aug 2, 2020
@Athospd
update test for tune. related to #22
a568413 
The test is failing because of sample_size = tune() for lightgbm.
@Athospd
Copy link
Member Author

Athospd commented Aug 2, 2020

It might be an issue with {dials} itself.

@siegfried
Copy link
Contributor

I think this can be fixed by replacing sample_size with sample_prop here, according to dials' docs. Need a PR?

@siegfried siegfried mentioned this issue Jun 1, 2021
Merged
@siegfried
Copy link
Contributor

PR is ready for review. Thanks.

@p-schaefer p-schaefer mentioned this issue Oct 25, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use sample_prop instead of sample_size siegfried/treesnip
2 participants
@siegfried @Athospd