Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add probe_sysroot_crate and emit_sysroot_crate #9

Merged
merged 3 commits into from
Aug 19, 2019

Conversation

leo60228
Copy link
Contributor

Copy link
Owner

@cuviper cuviper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a few minor tweaks, please.

src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
@cuviper cuviper merged commit 0f87a09 into cuviper:master Aug 19, 2019
@cuviper
Copy link
Owner

cuviper commented Aug 19, 2019

Thanks again -- I've published autocfg 0.1.6.

@gnzlbg
Copy link

gnzlbg commented Aug 24, 2019

I suspect this (the 0.1.6 release) causes a segfault that breaks libc crate CI on x86_64-unknown-freebsd: https://cirrus-ci.com/task/6196089037783040

@cuviper
Copy link
Owner

cuviper commented Aug 24, 2019

I suspect this (the 0.1.6 release) causes a segfault

That would be really weird, since there's no unsafe, and this PR should just be dead code if you're not using it. But it seems you've now identified a different root cause in rust-lang/libc#1489.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants