-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no_std support #95
no_std support #95
Conversation
See also #92 -- but you did it without a feature, which avoids the breaking change there. I would still rather be more conservative about MSRV though, since 1.36 is very recent. Maybe instead we can make this conditional on the version, detected from a build script? My own |
Looks like a dependency of rand increased the MSRV upstream. |
Ugh, that's annoying. It may be better for us to commit a safe/compatible |
|
Looks interesting. Can this PR formulate the goals and gains that come from this change? The |
@cuviper Wait, no, I just forgot that I switched to Rust 2018 in the initial PR... |
37fe523
to
344765f
Compare
No idea why the doctests aren't compiling... |
//let ac = autocfg::new(); | ||
//ac.emit_sysroot_crate("std"); | ||
//ac.emit_sysroot_crate("alloc"); | ||
autocfg::emit("std"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this do? Commit logs don't explain it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would blindly emit a std
config value. I suppose they were doing that as a stopgap until the commented crate tests were available -- that's now in autocfg 0.1.6.
Also, there is no reason to require Rust 1.36 for alloc — before Rust 1.36, it should still compile using std. |
This bumps the MSRV to 1.36, since it requires the
alloc
crate. Closes #94.