-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support building without libstd #106
Conversation
I also looked at autocfg to figure out how to test this. ⚙️ I have a worry that other "no_std" using crates are going to be disappointed in this (3) scheme, when they can't test this with crate features as we normally do. I still lean towards this being the morally right way to handle no_std; we build without it because it is not available. I'm looking for a simpler no-std hasher than ahash (since it depends on a lot of stuff). |
The main hazard I see in leaving this implicit is that users could end up depending on But I am in the camp that losing
Maybe |
Uses shepmaster's hash crate for testing, it's simple and no-std, tip by cuviper.
(Due to using the ::with_capacity method.)
Recast version of #95 by @leo60228
new
etc is not available without std — one has to use the others likewith_hasher
ordefault
. Theindexmap!
macros depend on these as well, and require std too.This approach, in particular (3) is novel, and thus it is out for wider requests for comments.
A no-std indexmap has been requested by petgraph.
Fixes #94
Closes #95
Closes #92