Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autohide for popup should be changed #2713

Closed
2 tasks done
valeriyvan opened this issue Jan 24, 2021 · 6 comments · Fixed by #2809
Closed
2 tasks done

Autohide for popup should be changed #2713

valeriyvan opened this issue Jan 24, 2021 · 6 comments · Fixed by #2809
Assignees
Labels
bug Something isn't working

Comments

@valeriyvan
Copy link

valeriyvan commented Jan 24, 2021

My actions before raising this issue

Currently if label selected in dropdown is inside of bounds of popup, popup stays open allowing annotator to choose labelling method pressing [Shape] or [Track] buttons:

1

But if selected label is beyond bounds of popup, it hides. Annotator has to open popup once again to choose labelling method by pressing [Shape] or [Track] buttons.:

2a

Expected Behaviour

In both cases popup should not hide allowing annotator press [Shape] or [Track] buttons.

Current Behaviour

Popup hides unexpectedly. Annotator has to open popup again.

Possible Solution

Possible solution: if selected labels is inside bounds of popup, behaviour stays the same - popup hides. If selected label is beyond bounds of popup, it stays open until user presses [Shape] or [Track] buttons or until user moves mouse so that mouse pointer goes beyond right edge of popup (mouse y coordinate become greater then popup's greatest y coordinate).

Steps to Reproduce (for bugs)

Look gifs attached.

Context

Your Environment

  • Git hash commit (git log -1): 226c2f2
  • Docker version docker version (e.g. Docker 17.0.05): 20.10.2
  • Are you using Docker Swarm or Kubernetes? n/a
  • Operating System and version (e.g. Linux, Windows, MacOS): n/a
  • Code example or link to GitHub repo or gist to reproduce problem: n/a
  • Other diagnostic information / logs: n/a

Next steps

n/a

@bsekachev
Copy link
Member

Duplicate of #2230

@bsekachev bsekachev marked this as a duplicate of #2230 Jan 25, 2021
@valeriyvan
Copy link
Author

Duplicate of #2230

Yes, but #2230 is about different popups.

@valeriyvan
Copy link
Author

Any plans to fix?

@bsekachev
Copy link
Member

Yes, we have plans to fix it.

@bsekachev bsekachev added this to the 1.3.0-alpha milestone Jan 26, 2021
@bsekachev bsekachev self-assigned this Jan 26, 2021
@bsekachev bsekachev added the bug Something isn't working label Jan 26, 2021
@valeriyvan
Copy link
Author

Yes, we have plans to fix it.

Create! Does it fit next release?

@bsekachev
Copy link
Member

We will try to implement it earlier than in next release. It will be available in develop branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants