Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved maintanance of popups visibility #2809

Merged
merged 3 commits into from
Feb 20, 2021
Merged

Improved maintanance of popups visibility #2809

merged 3 commits into from
Feb 20, 2021

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Feb 15, 2021 •
edited
Loading

Motivation and context

Resolved #2713
Resolved #2230

How has this been tested?

Manual testing

@dvkruchinin
We need a test to cover this case
Good gif to reproducing: https://user-images.githubusercontent.com/1630974/105646611-0fa2b880-5ea1-11eb-95ea-45a9c214491e.gif

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@bsekachev bsekachev added the bug Something isn't working label Feb 15, 2021
@coveralls
Copy link

coveralls commented Feb 15, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 70.828% when pulling 490a5c7 on bs/fixed_issue_2713_2230 into 7720a8f on develop.

@dvkruchinin
Copy link
Contributor

We need a test to cover this case

The test will be prepared.

@bsekachev bsekachev merged commit 6f0215d into develop Feb 20, 2021
@bsekachev bsekachev deleted the bs/fixed_issue_2713_2230 branch February 20, 2021 10:11
kenu pushed a commit to kenu/cvat that referenced this pull request Feb 23, 2021
@kenu
Improved maintanance of popups visibility (cvat-ai#2809)
01b95d3 
* Manual handling of popovers visibility

* Updated version & changelog, added minor comments

* Removed extra user hook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vnishukov vnishukov vnishukov approved these changes

@nmanovic nmanovic Awaiting requested review from nmanovic

Assignees

@vnishukov vnishukov

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Autohide for popup should be changed AI tools windows closes after model selection
4 participants
@bsekachev @coveralls @dvkruchinin @vnishukov