Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Host Container on Docker Hub #7

Closed
JulianWgs opened this issue Jul 12, 2018 · 19 comments · Fixed by #2766
Closed

Host Container on Docker Hub #7

JulianWgs opened this issue Jul 12, 2018 · 19 comments · Fixed by #2766
Assignees
@azhavoro
Labels
enhancement New feature or request

Comments

@JulianWgs
Copy link

Could you please connect this repository to docker hub. This way it would be possible just to download to already built container, since the build process is rather lengthy.
@nmanovic nmanovic self-assigned this Jul 12, 2018
@nmanovic nmanovic added the enhancement New feature or request label Jul 12, 2018
@nmanovic
Copy link
Contributor

Hi,

Let's try to do that. It can be a nice feature especially if you want to try the tool quickly. There are several problems with the approach:

  • If the user wants to change configuration it is necessary to build the image again but probably it will be much faster
  • There are several options to build the image (e.g. with TF or without TF)

But in any case it will be a good experiment. We will see how much user will decide to use the image out of the box.

@nmanovic nmanovic added this to the Release 0.2 milestone Jul 22, 2018
@nmanovic
Copy link
Contributor

Hi,

It seems that the feature isn't so easy as it looks like. Our image is based on Ubuntu. Ubuntu has Intellectual property rights policy:

Any redistribution of modified versions of Ubuntu must be approved, certified or provided by Canonical if you are going to associate it with the Trademarks. Otherwise you must remove and replace the Trademarks and will need to recompile the source code to create your own binaries. This does not affect your rights under any open source licence applicable to any of the components of Ubuntu. If you need us to approve, certify or provide modified versions for redistribution you will require a licence agreement from Canonical, for which you may be required to pay. For further information, please contact us (as set out below).

As far as I understand any image which is based on Ubuntu and redistributed through Docker Hub violates the policy. In general to be compliant it is necessary to use another distribution and check all packages which it includes by default. It is a big piece of work.

Thus I have decided to close the issue. Probably it is better to invest time into creating a demo server.

@JulianWgs
Copy link
Author

I don't think this policy applies to docker images using ubuntu as the base image.

  1. Take a look at https://github.com/sameersbn/docker-redmine (and other projects from sameersbn). Its also using a ubuntu base image. The project is over 4 years old and has over 800 commits. I think if canonical would have something against that, they wouldve done something.
  2. The docker image is officially by canonical and nothing on https://hub.docker.com/_/ubuntu/ says it is illegal to redistribute ubuntu based images. If I would be on there legal team, I would have definitely put a hint there!

However those are not definitive proofs, but reasons to reopen the issue.

If you tell me how to convince you that a docker image would be legal, then I will take care of it.
Greetings!

@nmanovic
Copy link
Contributor

@JulianWgs ,

  1. Unfortunately I cannot accept it as a proof. Maybe I'm wrong but I have to follow strict policies and guidelines. Also I consulted with experts in this area.
  2. Intellectual property rights policy has the following statements:

You can redistribute Ubuntu, but only where there has been no modification to it.

You can redistribute Ubuntu in its unmodified form, complete with the installer images and packages provided by Canonical (this includes the publication or launch of virtual machine images).

If anybody creates and supports images for CVAT we will be glad to specify the information somethere (need to check that). I will reopen the issue. Maybe someone from community will find a solution.

P.S. But I believe it is much better to spend time and energy to build a demo server.

@nmanovic nmanovic reopened this Jul 25, 2018
@nmanovic nmanovic added the wontfix This will not be worked on label Jul 29, 2018
@nmanovic nmanovic removed this from the Release 0.2.0 milestone Aug 13, 2018
@nmanovic nmanovic added this to the Undefined milestone Sep 20, 2018
bsekachev pushed a commit that referenced this issue Sep 26, 2018
Some AAM refactoring #7
6651637
bsekachev pushed a commit that referenced this issue Oct 15, 2018
Some AAM refactoring #7
aa5f9ed
bsekachev pushed a commit that referenced this issue Oct 17, 2018
Some AAM refactoring #7
302526c
@nmanovic
Copy link
Contributor

Nice post: https://www.reddit.com/r/linux/comments/3ezwi4/canonical_explains_its_ip_policy_regarding_docker/

@JulianWgs
Copy link
Author

So why isnt this happening then? Do you need help?

@nmanovic
Copy link
Contributor

nmanovic commented Mar 1, 2019

Hi @JulianWgs ,

It states that we cannot redistribute ubuntu docker image:

Redistribution of non modified Ubuntu images is OK

Distributing a Docker file (a text file) containing the words "FROM ubuntu" is permitted

Private distribution of Docker images containing Ubuntu to your friends is OK if you are able to apply the Canonical definition of personal use (someone you are confortable giving root).

Contact Canonical for everything else (get a license, it's not explicitely permitted)

@Langhalsdino
Copy link
Contributor

Why not switching to debian?

I am currently trying to get cvat up and running in kubernetes. In the process i started to change the dockerfiles to get faster builds.

For the docker.ui simply switch the image to:
FROM node:10.16.3-buster-slim AS cvat-ui

I will create a pull request after i managed to get it working in our kubernetes cluster.

@nmanovic
Copy link
Contributor

@Langhalsdino , if you can help us and optimize CVAT images it will be awesome. Look forward for PRs from you.

@Langhalsdino
Copy link
Contributor

since gitlab is currently down, i a have a little bit of time on my hand and try to move both two buster-slim :)

@Langhalsdino
Copy link
Contributor

@nmanovic I have no legal experience therefore, can you check wether or not we are allowed to publish software like ffmpeg, gstreamer0.10-ffmpeg, unrar-free provided by http://www.deb-multimedia.org (non-free) on hub.docker.com? Furthermore check the rest of the used software stack?

I will create a pull request with my changes to the docker files and reference them here.

It seems like it worked, but i have to check a few more thinks before creating the PR :)

@Langhalsdino Langhalsdino mentioned this issue Nov 28, 2019
Closed
@Langhalsdino
Copy link
Contributor

Looking for some help testing the new docker container (CUDA support, ...).

Furthermore, ci integration for publishing it on Docker Hub is needed :)
What is the timeline on this issue?

@nmanovic nmanovic removed the wontfix This will not be worked on label Nov 29, 2019
@nmanovic
Copy link
Contributor

It seems that OpenVINO is on DockerHub. Thus CVAT image also can be placed on DockerHub.

https://hub.docker.com/u/openvino
http://docs.openvinotoolkit.org/latest/_docs_install_guides_installing_openvino_docker_linux.html

@nmanovic
Copy link
Contributor

cvat_licenses.xlsx

@Langhalsdino
Copy link
Contributor

Langhalsdino commented Jan 15, 2020 •
edited
Loading

Thank you for sharing the software licenses @nmanovic and doing all the work to collect them :)

I checked a few of the unknown licenses and if I am not mistaken unrar could be replaced by their open-source counterpart unrar-free as shown in the Dockerfile and prev. pull request: https://github.com/opencv/cvat/blob/c7d1c82aeb0a81f26f03673050c33de83b57bfb7/Dockerfile

Furthermore, the GLP V2 license can replace UNKNOWN in the excel of pkg-config is GLP V2
SRC: https://www.freedesktop.org/wiki/Software/pkg-config/

Why is CVAT needing the following X11 extensions:
libxext6 -> X11 miscellaneous extension library
libsm6 -> X11 Session Management library
Since Ubuntu is moving from X11 to Wayland there should be a few issues coming up, if we stick with X11, right?

So what are the next steps for moving forward to a prebuild DockerHub version of CVAT?

Furthermore, why are we using Ubuntu and not Debian?

@nmanovic
Copy link
Contributor

@Langhalsdino ,

The file is only for my reference. I'm working now to clean up packages and prepare dockerfiles for DockerHub.

@nmanovic
Copy link
Contributor

nmanovic commented Feb 7, 2020 •
edited
Loading

ip-plan.zip

server_apt_pkgs.txt

@bsekachev bsekachev mentioned this issue Feb 17, 2020
Closed
@l3xis l3xis mentioned this issue Mar 1, 2020
Closed
@nmanovic
Copy link
Contributor

nmanovic commented Mar 6, 2020 •
edited
Loading

branch: https://github.com/opencv/cvat/tree/az/data_chunk_streaming

npm_audit.txt
bandit_config.txt
bandit_results.txt

@nmanovic
Copy link
Contributor

bandit_cvat_results.txt

bandit_datumaro_results.txt

@Langhalsdino Langhalsdino mentioned this issue Aug 3, 2020
Merged
8 tasks
@azhavoro azhavoro mentioned this issue Feb 4, 2021
Merged
6 tasks
@bsekachev bsekachev assigned azhavoro and unassigned nmanovic Feb 5, 2021
TOsmanov referenced this issue in TOsmanov/cvat Aug 23, 2021
@codacy-badger
Add Codacy badge (#7)
c653984
korshunovdv pushed a commit to Evocargo/cvat that referenced this issue Aug 23, 2021
# This is a combination of 2 commits.
1aa7b70 
# This is the 1st commit message:

# This is a combination of 3 commits.
# This is the 1st commit message:

# This is a combination of 8 commits.
# This is the 1st commit message:

setup config

Add built from source code

one domain name insted of two

add installation guide

update gitignore

# This is the commit message cvat-ai#2:

delete serverless (nuclio)

# This is the commit message cvat-ai#3:

add backup script to gitignore

# This is the commit message cvat-ai#4:

Add script for backup data

# This is the commit message cvat-ai#5:

Add docstrings for backup script

# This is the commit message cvat-ai#6:

Update backup script to delete after 30 days

# This is the commit message cvat-ai#7:

Fix backup error

# This is the commit message cvat-ai#8:

Update backup rules, and decrease cache size from 1 Tb to 10 Gb

# This is the commit message cvat-ai#2:

one domain name insted of two

# This is the commit message cvat-ai#3:

add installation guide

# This is the commit message cvat-ai#2:

delete serverless (nuclio)
summeroff pushed a commit to summeroff/cvat that referenced this issue Aug 14, 2022
@AlexeyAlexeevXperienceAI @bsekachev
@sizov-kirill @nmanovic
86 improve uiux on create task page (cvat-ai#7)
fbcf758 
* Update label form

Remove Done button
Add closing by Esc
Add continuing by Enter

* disable autocomplete on label form

* Update submit behavior on create task

Change one submit button to two: "submit and open" and "submit and continue"

* Update submit behavior on create project

Change one submit button to two: "submit and open" and "submit and continue"

* fix eslint error

* change tests

* Add changes in changelog

* update version cvat-ui

* move of empty name handler logic when create label

* change handler errors on create project

* change text of buttons

* revert change yarn.lock

* Fixed eslint pipeline

* fix eslint error on test

* fix several tests

* fix several tests

* fix several tests

* fix several tests

Co-authored-by: Boris <sekachev.bs@gmail.com>
Co-authored-by: kirill-sizov <sizow.k.d@gmail.com>
Co-authored-by: Nikita Manovich <nikita@cvat.ai>
@il-nietos il-nietos mentioned this issue Mar 7, 2023
Closed
This was referenced Apr 26, 2024
Open
Merged
Merged
Merged
@rragundez rragundez mentioned this issue Jul 11, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@azhavoro azhavoro

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added CI workflow to publish CVAT images cvat-ai/cvat
4 participants
@Langhalsdino @JulianWgs @nmanovic @azhavoro