Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CI workflow to publish CVAT images #2766

Merged
merged 8 commits into from
Feb 12, 2021
Merged

Added CI workflow to publish CVAT images #2766

merged 8 commits into from
Feb 12, 2021

Conversation

azhavoro
Copy link
Contributor

@azhavoro azhavoro commented Feb 4, 2021

Motivation and context

resolve #7

How has this been tested?

Manually

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@coveralls
Copy link

coveralls commented Feb 4, 2021

Coverage Status

Coverage increased (+0.02%) to 69.778% when pulling ad4d3ac on az/public_images into 9a56e7e on develop.

@azhavoro azhavoro changed the title [WIP] Added CI workflow to publish CVAT images Added CI workflow to publish CVAT images Feb 5, 2021
docker-compose.dev.yml Outdated Show resolved Hide resolved
Co-authored-by: Nikita Manovich <nikita.manovich@intel.com>
README.md Outdated Show resolved Hide resolved
LICENSE Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
@nmanovic
Copy link
Contributor

nmanovic commented Feb 8, 2021

@azhavoro , don't forget to add news into CHANGELOG.md

Copy link
Contributor

@nmanovic nmanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change comments for ffmpeg code and add info to CHANGELOG. Great job!

@nmanovic
Copy link
Contributor

nmanovic commented Feb 8, 2021

@azhavoro , also need to fix codacy issues.

@nmanovic
Copy link
Contributor

nmanovic commented Feb 9, 2021

@azhavoro , any updates?

Copy link
Contributor

@nmanovic nmanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! I didn't test it, just reviewed the code. For me it looks fine.

@nmanovic nmanovic merged commit 108947f into develop Feb 12, 2021
@nmanovic nmanovic deleted the az/public_images branch February 12, 2021 08:18
@nmanovic
Copy link
Contributor

@azhavoro , could you please notify all stakeholders about the achievement (gitter, Intel teams)? Need to clear emphasize why it is important (speed of the build, easy to deploy, alternative channel to distribute CVAT, etc).

@azhavoro
Copy link
Contributor Author

@azhavoro , could you please notify all stakeholders about the achievement (gitter, Intel teams)? Need to clear emphasize why it is important (speed of the build, easy to deploy, alternative channel to distribute CVAT, etc).

Sure

@azhavoro azhavoro linked an issue Feb 16, 2021 that may be closed by this pull request
kenu pushed a commit to kenu/cvat that referenced this pull request Feb 23, 2021
* Configured CI workflow for public images
* updated license headers
* align list item indent rule for remarklint and prettier
* updated changelog

Co-authored-by: Nikita Manovich <nikita.manovich@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alternative installation method Host Container on Docker Hub
3 participants