Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cvat_worker_chunks Container Does Not Inherit Database Environment Variables #8846

Closed
2 tasks done
NoahNour opened this issue Dec 19, 2024 · 0 comments
Closed
2 tasks done
Labels
bug Something isn't working

Comments

@NoahNour
Copy link

Actions before raising this issue

  • I searched the existing issues and did not find anything similar.
  • I read/searched the docs

Steps to Reproduce

Deploy CVAT using Docker Compose with custom database environment variables set in the .env file.
Start the CVAT services.
Inspect the environment variables of the cvat_worker_chunks container and observe that the specified variables are not present.

Expected Behavior

The cvat_worker_chunks container should inherit database-related environment variables from the .env file, ensuring proper connectivity.

Possible Solution

No response

Context

The cvat_worker_chunks container does not receive essential database-related environment variables, such as CVAT_POSTGRES_HOST, from the .env file. As a result, it uses hardcoded default values. To make CVAT work correctly, I had to manually specify these variables in the docker-compose.override.yml file.

Environment

No response

@NoahNour NoahNour added the bug Something isn't working label Dec 19, 2024
zhiltsov-max pushed a commit that referenced this issue Dec 25, 2024
…#8871)

### Motivation and context
There was an oversight in the `docker-compose.external_db.yml` file
where the newly added service, `cvat_worker_chunks`, was not configured
to extend the external database environment variables. This resulted in
the `cvat_worker_chunks` container failing to start properly, as it was
stuck in an infinite wait state for a non-existent database connection.

Consequently, jobs failed to open, and attempting to access them
repeatedly caused the Data API to return a 429 status code.

An existing issue related to this problem was reported here:
#8846. However, the author closed
the issue without submitting a pull request to resolve it.

### How has this been tested?

### Checklist
- [x] I submit my changes into the `develop` branch
- [ ] I have created a changelog fragment
- [~] I have updated the documentation accordingly
- [~] I have added tests to cover my changes
- [x] I have linked related issues (see [GitHub docs](

https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))
- [ ] I have increased versions of npm packages if it is necessary

([cvat-canvas](https://github.com/cvat-ai/cvat/tree/develop/cvat-canvas#versioning),

[cvat-core](https://github.com/cvat-ai/cvat/tree/develop/cvat-core#versioning),

[cvat-data](https://github.com/cvat-ai/cvat/tree/develop/cvat-data#versioning)
and

[cvat-ui](https://github.com/cvat-ai/cvat/tree/develop/cvat-ui#versioning))

### License

- [x] I submit _my code changes_ under the same [MIT License](
https://github.com/cvat-ai/cvat/blob/develop/LICENSE) that covers the
project.
  Feel free to contact the maintainers if that's a concern.


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Introduced a new service for improved chunk processing in the CVAT
application deployment.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant