added cvat_worker_chunk service in docker-compose.external_db.yml
#8871
Conversation
WalkthroughThe pull request introduces a new service called Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docker-compose.external_db.yml (1)
Line range hint
1-35: Documentation update recommendedSince this is a new service component, consider updating the documentation to:
- Describe the purpose and responsibilities of the
cvat_worker_chunksservice- Explain its role in the overall CVAT architecture
- Document any specific configuration requirements or dependencies
This will help maintainers and users understand the service's role in the system.
Would you like me to help draft the documentation updates or create a GitHub issue to track this task?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docker-compose.external_db.yml(1 hunks)
🔇 Additional comments (2)
docker-compose.external_db.yml (2)
30-30: LGTM! Service configuration follows established patterns
The addition of cvat_worker_chunks service with the backend-settings configuration is correct and consistent with other worker services. This addresses the reported issue where the service was failing to connect to the external database.
30-30: Verify service dependencies
Let's verify if this service has any additional dependencies beyond the database connection that might need configuration.
✅ Verification successful
Let me gather more information about the service configurations and dependencies.
Let me check the backend settings and dependencies that are referenced in the configurations.
Service dependencies are properly configured
The cvat_worker_chunks service inherits all necessary configurations:
- Database connection settings through
backend-settingsanchor in external DB setup - Core dependencies (Redis in-memory, Redis on-disk, DB) through
backend-deps - Standard environment variables through
backend-envincluding database, Redis, logging, and proxy settings - Data volume mount at
/home/django/data
The service is properly configured with all required dependencies and doesn't need additional configuration beyond what's inherited from the backend settings.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for any additional service dependencies or configurations needed for cvat_worker_chunks
# Search for cvat_worker_chunks related configurations in other compose files
echo "Checking other compose files for cvat_worker_chunks configurations..."
rg -l "cvat_worker_chunks:" --type yaml
# Search for any documentation or comments about the service
echo "Checking for existing documentation about the service..."
rg -i "worker.?chunks" --type md
Length of output: 594
Script:
#!/bin/bash
# Check the actual configurations in the compose files
echo "Checking cvat_worker_chunks configurations in docker-compose.yml..."
rg -A 10 "cvat_worker_chunks:" docker-compose.yml
echo -e "\nChecking cvat_worker_chunks configurations in docker-compose.external_db.yml..."
rg -A 10 "cvat_worker_chunks:" docker-compose.external_db.yml
echo -e "\nChecking cvat_worker_chunks configurations in tests/docker-compose.minio.yml..."
rg -A 10 "cvat_worker_chunks:" tests/docker-compose.minio.yml
echo -e "\nChecking cvat_worker_chunks configurations in tests/docker-compose.file_share.yml..."
rg -A 10 "cvat_worker_chunks:" tests/docker-compose.file_share.yml
# Check for any environment variables or dependencies
echo -e "\nChecking for environment variables and dependencies..."
rg "depends_on.*cvat_worker_chunks" --type yaml
rg "environment:.*cvat_worker_chunks" -A 10 --type yaml
Length of output: 1899
Script:
#!/bin/bash
# Check the backend settings and dependencies
echo "Checking backend settings anchor..."
rg "backend-settings: &backend-settings" -A 10 docker-compose.external_db.yml
echo -e "\nChecking backend dependencies anchor..."
rg "backend-deps: &backend-deps" -A 10 docker-compose.yml
echo -e "\nChecking backend environment anchor..."
rg "backend-env: &backend-env" -A 10 docker-compose.yml
# Check the worker chunks implementation
echo -e "\nChecking worker chunks implementation..."
rg -g "*.py" -l "worker.chunks"
Length of output: 1543
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8871 +/- ##
===========================================
+ Coverage 73.88% 73.90% +0.02%
===========================================
Files 408 408
Lines 44108 44108
Branches 3986 3986
===========================================
+ Hits 32587 32597 +10
+ Misses 11521 11511 -10
|
|
Thank you for contributing into the project! |
Motivation and context
There was an oversight in the
docker-compose.external_db.ymlfile where the newly added service,cvat_worker_chunks, was not configured to extend the external database environment variables. This resulted in thecvat_worker_chunkscontainer failing to start properly, as it was stuck in an infinite wait state for a non-existent database connection.Consequently, jobs failed to open, and attempting to access them repeatedly caused the Data API to return a 429 status code.
An existing issue related to this problem was reported here: #8846. However, the author closed the issue without submitting a pull request to resolve it.
How has this been tested?
Checklist
developbranch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.
Summary by CodeRabbit