-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project export with 3d tasks #3502
Conversation
Co-authored-by: Maxim Zhiltsov <maxim.zhiltsov@intel.com>
…t/cvat into dk/project-export
@@ -940,9 +924,11 @@ def map_label(name): return label_cat.find(name)[0] | |||
return convert_cvat_anno_to_dm(cvat_frame_anno, label_attrs, map_label, self._format_type, self._dimension) | |||
|
|||
class CVATProjectDataExtractor(datumaro.Extractor, CVATDataExtractorMixin): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think of implementing this class as (roughly):
task_datasets = { task_id: make_task_dataset(task) for task_id, task in tasks }
# append name mangling and other transforms like
for task_id, task_dataset in task_datasets.items():
task_dataset.transform('rename', ...)
dataset = Dataset.from_extractors(*task_datasets)
I am not expert in |
@zhiltsov-max Do you have any new comments on the PR? I didn't see your approve |
@bsekachev, fixed |
attributes["track_id"] = -1 | ||
index += 1 | ||
|
||
dm_item = datumaro.DatasetItem(id=osp.split(frame_data.name)[-1].split('.')[0], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Fix to my reported problem 3: Use either
os.path.splitext()
orstr.rsplit(s, maxsplit=1)
-
Use of
split()
here does not conform to 2d formats and established CVAT behavior here, because 2d formats preserve the relative path information (to handle the problem with frames with same names in different dirs). Yes, it was discussed in the original 3d PR, but they refused to change it.
Fixed. I'm not sure about the red color on menu items, there is already a red button on the delete modal.
Fixed Other comments are not very related to this PR so I moved them to a separate issue. |
@dvkruchinin, hi, can you add tests for this feature, please? |
Sure. A test will be prepared. |
Motivation and context
Added ability to export project dataset with 3d tasks
Depends on #3365
How has this been tested?
Manually
Checklist
develop
branch- [ ] I have updated the documentation accordingly- [ ] I have added tests to cover my changes- [ ] I have linked related issues (read github docs)- [ ] I have increased versions of npm packages if it is necessary (cvat-canvas,cvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.