Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project export with 3d tasks #3502
Project export with 3d tasks #3502
Changes from 77 commits
c53e062
46e89b0
22fafe3
7f4a349
4a5bc3a
c57ab56
04d14c5
f6b833f
d45bec8
b23a9ba
4c22e11
a4d6094
aadc83c
bcd2034
3aa16a1
b59ab03
5d9b512
a914d05
3b480fa
2647eb9
15d226a
3da98c4
d70ee77
b8b3d9c
e1f8db6
98c9083
84f8b7a
4f8d28d
29ffac1
4e2aac1
5a48dfc
ff19e71
3e6d7df
dc45b9f
6c683ac
abdb59f
f4c4e87
76c073c
370f337
141f6a6
c076584
1f5f6f2
7d1b9cf
3be269c
f129f76
dc4b56a
cd67f5b
c955995
7e9fcaa
4be0540
415e275
e6c95a2
4a66693
c7ed863
0687808
7e412f4
4fe5598
e635db3
e9f1fc1
0a06baf
1387b2f
23d47dc
cbb7a1e
566e490
42a974e
4e4b37d
333bc88
9952d51
f5c89ef
a73122f
5e4f248
bbaf8d6
ddf8c3b
bed869c
d2c03c9
88a3ace
f1cb156
ac2790f
84f328c
579d2b4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix to my reported problem 3: Use either
os.path.splitext()
orstr.rsplit(s, maxsplit=1)
Use of
split()
here does not conform to 2d formats and established CVAT behavior here, because 2d formats preserve the relative path information (to handle the problem with frames with same names in different dirs). Yes, it was discussed in the original 3d PR, but they refused to change it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think of implementing this class as (roughly):