Fix loss of rotation in CVAT format #5407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will look at this failed test with 3D.. |
|
Okay, the test compares these two images and expect they the same, what actually true for eyes.
But not for the algorithm: Also: That is just explanation why I am gonna to increase threshold.. |
5 tasks
nmanovic
reviewed
Dec 5, 2022
| response_data = self._test_get_annotations_from_task(username, tasks[1]["id"]) | ||
| task2_rotation = response_data["shapes"][0]["rotation"] | ||
|
|
||
| assert task1_rotation == task2_rotation |
There was a problem hiding this comment.
Does the check help us to prevent a regression?
There was a problem hiding this comment.
Yes, this test fails without a fix.
nmanovic
approved these changes
Dec 5, 2022
Merged
mikhail-treskin
pushed a commit
to retailnext/cvat
that referenced
this pull request
Jul 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Fix #4378
How has this been tested?
Checklist
developbranchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.