Fix creation of tasks with Git repositories via the SDK #5409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpecLad
requested review from
azhavoro,
bsekachev and
nmanovic
as code owners
|
FYI, there are 4 independent issues I had to fix to make this work; see the individual commits for more explanation. |
SpecLad
force-pushed
the
cvat-sdk-git
branch
2 times, most recently
from
4fcc9dd to
040256f
Compare
The main goal is to align authentication logic between `dataset_repo` and the rest of the API. In particular, the common logic disables CSRF checks for queries that have token authentication, which will allow the Git API to be used from the SDK. The interactive HTML API pages that DRF provides are pretty nice too. For one of the endpoints, fix the UI to pass the correct Content-Type, otherwise, DRF rejects the request.
There's already format autodetection code in `CVATGit.initial_create`, might as well let the client use it by not specifying a format.
The various server/worker processes may be running in separate containers, in which case `~/.ssh/ssh.pid` may refer to a different file in each container. Use `~/keys/ssh.pid` instead, because that is mounted from a shared volume.
|
Fix for failed 3D test: 3f097f5 |
zhiltsov-max
reviewed
Dec 2, 2022
There was a problem hiding this comment.
The PR looks good to me. Maybe, we could add some info about the expected format in the CLI output and in the task creating function docs. A link to the description page may be enough for this .
Merged
Maybe, but that's not related to the bug. 🙂 I didn't change the "face" of the API, so I don't think documenting it should be part of this PR. |
zhiltsov-max
reviewed
Dec 5, 2022
zhiltsov-max
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Fixes #4365.
How has this been tested?
SDK unit tests + I did some Git-related operations via the UI to make sure they weren't broken.
Checklist
developbranch[ ] I have updated the documentation accordingly[ ] I have increased versions of npm packages if it is necessary (cvat-canvas,cvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.