Fix REST API tests #5416
Merged
Fix REST API tests #5416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/check |
|
❌ Some checks failed |
|
/check |
|
❌ Some checks failed |
sizov-kirill
reviewed
Dec 2, 2022
tests/python/shared/fixtures/data.py
Outdated
Comment on lines
360
to
368
| def find(tasks, skip_tasks=None): | ||
| def _is_task_with_shapes(t): | ||
| if ( | ||
| skip_tasks is not None | ||
| and t["id"] in skip_tasks | ||
| or not annotations["task"][str(t["id"])]["shapes"] | ||
| ): | ||
| return False | ||
| return True |
There was a problem hiding this comment.
Can we use such solution?
Suggested change
| def find(tasks, skip_tasks=None): | |
| def _is_task_with_shapes(t): | |
| if ( | |
| skip_tasks is not None | |
| and t["id"] in skip_tasks | |
| or not annotations["task"][str(t["id"])]["shapes"] | |
| ): | |
| return False | |
| return True | |
| def find(tasks): | |
| def _is_task_with_shapes(t): | |
| if ( | |
| not t.get("data") | |
| or not annotations["task"][str(t["id"])]["shapes"] | |
| ): | |
| return False | |
| return True |
It won't make us always remember about skip_tasks.
Marishka17
force-pushed
the
mk/fix_tests
branch
from
0dec58a to
c698644
Compare
|
@bsekachev Are these e2e tests unstable? Or are they related with this PR? |
|
@kirill-sizov case_82_canvas3d_functionality_cuboid_opacity_outlined_borders.js This one was fixed: #5409 (comment) case_118_multi_tasks.js Was quite stable before, not sure why it is failed here. |
nmanovic
approved these changes
Dec 2, 2022
mikhail-treskin
pushed a commit
to retailnext/cvat
that referenced
this pull request
Jul 1, 2023
Fixed REST API tests after merging cvat-ai#5408 and cvat-ai#5396 to develop Co-authored-by: Boris Sekachev <sekachev.bs@gmail.com> Co-authored-by: Nikita Manovich <nikita@cvat.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Fixed REST API tests after merging #5408 and #5396 to develop