Fixed object states memory leak #6984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #6984 +/- ##
========================================
Coverage 82.58% 82.58%
========================================
Files 360 360
Lines 38914 38927 +13
Branches 3570 3570
========================================
+ Hits 32137 32149 +12
- Misses 6777 6778 +1
|
bsekachev
reviewed
Oct 12, 2023
|
|
||
| return () => { | ||
| canvasInstance.html().removeEventListener('canvas.zoom', geometryListener); | ||
| canvasInstance.html().removeEventListener('canvas.fit', geometryListener); | ||
| canvasInstance.html().addEventListener('canvas.reshape', geometryListener); |
There was a problem hiding this comment.
Probably it was the mistake. We need removeEventListener here. No need to change other things
bsekachev
approved these changes
Oct 12, 2023
bsekachev
reviewed
Oct 12, 2023
bsekachev
approved these changes
Oct 12, 2023
|
Let's merge. I do not think these changes may affect somehow rest api tests |
Closed
Merged
mikhail-treskin
pushed a commit
to retailnext/cvat
that referenced
this pull request
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
How has this been tested?
Checklist
developbranch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.