-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v2.7.6 #6995
Closed
Closed
Release v2.7.6 #6995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- Raise an issue to propose your change (https://github.com/opencv/cvat/issues). It helps to avoid duplication of efforts from multiple independent contributors. Discuss your ideas with maintainers to be sure that changes will be approved and merged. Read the [Contribution guide](https://opencv.github.io/cvat/docs/contributing/). --> <!-- Provide a general summary of your changes in the Title above --> ### Motivation and context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. Describe your changes in detail, add screenshots. --> ### How has this been tested? <!-- Please describe in detail how you tested your changes. Include details of your testing environment, and the tests you ran to see how your change affects other areas of the code, etc. --> ### Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. If an item isn't applicable for some reason, then ~~explicitly strikethrough~~ the whole line. If you don't do that, GitHub will show incorrect progress for the pull request. If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [ ] I submit my changes into the `develop` branch - [ ] I have created a changelog fragment <!-- see top comment in CHANGELOG.md --> - [ ] I have updated the documentation accordingly - [ ] I have added tests to cover my changes - [ ] I have linked related issues (see [GitHub docs]( https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword)) - [ ] I have increased versions of npm packages if it is necessary ([cvat-canvas](https://github.com/opencv/cvat/tree/develop/cvat-canvas#versioning), [cvat-core](https://github.com/opencv/cvat/tree/develop/cvat-core#versioning), [cvat-data](https://github.com/opencv/cvat/tree/develop/cvat-data#versioning) and [cvat-ui](https://github.com/opencv/cvat/tree/develop/cvat-ui#versioning)) ### License - [ ] I submit _my code changes_ under the same [MIT License]( https://github.com/opencv/cvat/blob/develop/LICENSE) that covers the project. Feel free to contact the maintainers if that's a concern.
….78 (#6931) Co-authored-by: snyk-bot <snyk-bot@snyk.io> Co-authored-by: Roman Donchenko <roman@cvat.ai>
This automates the first half of the current release process. The second half will be implemented by another workflow. The reason why it can't all be done in a single workflow is that it's useful to let developers inspect what'll go into the release before actually publishing it, and to apply any last-minute fixes, if necessary. It also allows CI to complete for the release PR. To support the new workflow, add a `--set` option to `update_version.py` that sets the version to a custom value.
```python "Exception caught in handler - \"not enough values to unpack (expected 3, got 2)\": Traceback (most recent call last): File \"/opt/nuclio/_nuclio_wrapper.py\", line 143, in serve_requests await self._handle_event(event) File \"/opt/nuclio/_nuclio_wrapper.py\", line 397, in _handle_event entrypoint_output = self._entrypoint(self._context, event) File \"/opt/nuclio/main.py\", line 29, in handler shape, state = context.user_data.model.infer(image, shape, states[i] if i < len(states) else None) File \"/opt/nuclio/model_handler.py\", line 56, in infer self.config['hp'], device=self.device) File \"/opt/nuclio/SiamMask/tools/test.py\", line 152, in siamese_init z_crop = get_subwindow_tracking(im, target_pos, p.exemplar_size, s_z, avg_chans) File \"/opt/nuclio/SiamMask/tools/test.py\", line 88, in get_subwindow_tracking r, c, k = im.shape ValueError: not enough values to unpack (expected 3, got 2) ```
I realized that I was fighting my editor, because we indent YAML files with 2 spaces, but `.editorconfig` specifies 4 spaces for all files. Align the config with reality.
When uploading annotations for the whole task that has few jobs our server splits tracks. Each track we divide into a few tracks in that way that each track corresponds to only one job and all shapes of the track do not extend beyond the frame range corresponding to that job. It mainly works, but we have a problem with skeleton tracks. Due to this problem we if upload skeleton tracks for the whole task all our tracks will be duplicated for each job but not split, it means that we will have tracks that extend beyond the frame range of jobs and it leads to bad side effects, in this case, our exported annotations from such task could be incorrect or we won't be able to export annotations at all. And the reason for this problem is this small bug, which this PR fixes. Our code really slices sub-tracks for the skeleton track, but after this slicing server doesn't save the result.
github-actions
bot
requested review from
azhavoro,
sizov-kirill,
zhiltsov-max,
bsekachev,
mdacoca,
SpecLad,
Marishka17 and
nmanovic
as code owners
October 12, 2023 11:23
Codecov Report
@@ Coverage Diff @@
## master #6995 +/- ##
==========================================
+ Coverage 82.58% 82.59% +0.01%
==========================================
Files 360 360
Lines 38914 38920 +6
Branches 3570 3570
==========================================
+ Hits 32137 32147 +10
+ Misses 6777 6773 -4
|
Will recreate this later to include more fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
Persist image filters across jobs
(Persist image filters across jobs #6953)
Splitting skeleton tracks on jobs
(Fix tracks splitting for tracks that have sub-tracks #6968)
Fixed Siammask tracker error on grayscale images
(Fixed Siammask tracker error on grayscale images #6982)
Fixed memory leak on client side when event listener was not removed together with its context
(Fixed object states memory leak #6984)
Fixed crash related to issue tries to mount to not existing parent
(Fixed crash related to issue tries to mount to not existing parent #6977)
Security
([Snyk] Security upgrade opencv-python-headless from 4.5.5.62 to 4.8.1.78 #6931)