Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Race condition for the task data upload request #7025

Merged
merged 6 commits into from
Oct 26, 2023
Merged

Race condition for the task data upload request #7025

merged 6 commits into from
Oct 26, 2023
+99 −79

Conversation

azhavoro
Copy link
Contributor

@azhavoro azhavoro commented Oct 18, 2023 •
edited
Loading

Motivation and context

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@azhavoro azhavoro marked this pull request as ready for review October 18, 2023 10:28
@codecov
Copy link

codecov bot commented Oct 18, 2023 •
edited
Loading

Codecov Report

Merging #7025 (5d68e23) into develop (8b0ec00) will increase coverage by 0.00%.
The diff coverage is 96.55%.

@@           Coverage Diff            @@
##           develop    #7025   +/-   ##
========================================
  Coverage    82.34%   82.35%           
========================================
  Files          361      361           
  Lines        39178    39179    +1     
  Branches      3585     3585           
========================================
+ Hits         32262    32265    +3     
+ Misses        6916     6914    -2
Components Coverage Δ
cvat-ui 77.31% <ø> (+0.01%) ⬆️
cvat-server 86.98% <96.55%> (-0.01%) ⬇️

@azhavoro azhavoro changed the title Az/bulk save server files Race condition for the task data upload request Oct 18, 2023
@azhavoro azhavoro requested review from SpecLad and removed request for nmanovic and Marishka17 October 18, 2023 19:44
@azhavoro @zhiltsov-max
Update cvat/apps/engine/serializers.py
5a3364d 
Co-authored-by: Maxim Zhiltsov <zhiltsov.max35@gmail.com>
SpecLad
SpecLad reviewed Oct 23, 2023
View reviewed changes
changelog.d/20231018_224126_andrey_bulk_save_server_files.md Outdated Show resolved Hide resolved
cvat/apps/engine/views.py Outdated Show resolved Hide resolved
cvat/apps/engine/views.py Outdated Show resolved Hide resolved
cvat/apps/engine/views.py Outdated Show resolved Hide resolved
@nmanovic nmanovic merged commit d274c18 into develop Oct 26, 2023
33 checks passed
@nmanovic nmanovic deleted the az/bulk_save_server_files branch October 26, 2023 07:15
@cvat-bot cvat-bot bot mentioned this pull request Nov 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marishka17 Marishka17 Marishka17 left review comments

@zhiltsov-max zhiltsov-max zhiltsov-max left review comments

@SpecLad SpecLad SpecLad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@azhavoro @SpecLad @zhiltsov-max @Marishka17 @nmanovic