-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v2.8.1 #7094
Merged
Merged
Release v2.8.1 #7094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- Raise an issue to propose your change (https://github.com/opencv/cvat/issues). It helps to avoid duplication of efforts from multiple independent contributors. Discuss your ideas with maintainers to be sure that changes will be approved and merged. Read the [Contribution guide](https://opencv.github.io/cvat/docs/contributing/). --> <!-- Provide a general summary of your changes in the Title above --> ### Motivation and context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. Describe your changes in detail, add screenshots. --> ### How has this been tested? <!-- Please describe in detail how you tested your changes. Include details of your testing environment, and the tests you ran to see how your change affects other areas of the code, etc. --> Manually with a modified version of the pipeline that uploads to TestPyPI. See successful run here: <https://github.com/SpecLad/cvat/actions/runs/6509890509/job/17745596516>. ### Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. If an item isn't applicable for some reason, then ~~explicitly strikethrough~~ the whole line. If you don't do that, GitHub will show incorrect progress for the pull request. If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] I submit my changes into the `develop` branch - ~~[ ] I have created a changelog fragment~~ <!-- see top comment in CHANGELOG.md --> - ~~[ ] I have updated the documentation accordingly~~ - ~~[ ] I have added tests to cover my changes~~ - ~~[ ] I have linked related issues (see [GitHub docs]( https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))~~ - ~~[ ] I have increased versions of npm packages if it is necessary ([cvat-canvas](https://github.com/opencv/cvat/tree/develop/cvat-canvas#versioning), [cvat-core](https://github.com/opencv/cvat/tree/develop/cvat-core#versioning), [cvat-data](https://github.com/opencv/cvat/tree/develop/cvat-data#versioning) and [cvat-ui](https://github.com/opencv/cvat/tree/develop/cvat-ui#versioning))~~ ### License - [x] I submit _my code changes_ under the same [MIT License]( https://github.com/opencv/cvat/blob/develop/LICENSE) that covers the project. Feel free to contact the maintainers if that's a concern.
Update develop after v2.8.0
<!-- Raise an issue to propose your change (https://github.com/opencv/cvat/issues). It helps to avoid duplication of efforts from multiple independent contributors. Discuss your ideas with maintainers to be sure that changes will be approved and merged. Read the [Contribution guide](https://opencv.github.io/cvat/docs/contributing/). --> <!-- Provide a general summary of your changes in the Title above --> ### Motivation and context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. Describe your changes in detail, add screenshots. --> This PR fixes some problems with TrackerMIL memory managment - Free up some memory after we are done with tracking - Stable memory consuption while tracking (no endlessly raising heap size) Open a task with quite large images 2k -> create a couple of tracks -> track a couple of frames: ![tracking](https://github.com/opencv/cvat/assets/50956430/087910dd-a0c8-4007-a25c-6952743c2f36) ### How has this been tested? <!-- Please describe in detail how you tested your changes. Include details of your testing environment, and the tests you ran to see how your change affects other areas of the code, etc. --> ### Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. If an item isn't applicable for some reason, then ~~explicitly strikethrough~~ the whole line. If you don't do that, GitHub will show incorrect progress for the pull request. If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [ ] I submit my changes into the `develop` branch - [ ] I have created a changelog fragment <!-- see top comment in CHANGELOG.md --> - [ ] I have updated the documentation accordingly - [ ] I have added tests to cover my changes - [ ] I have linked related issues (see [GitHub docs]( https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword)) - [ ] I have increased versions of npm packages if it is necessary ([cvat-canvas](https://github.com/opencv/cvat/tree/develop/cvat-canvas#versioning), [cvat-core](https://github.com/opencv/cvat/tree/develop/cvat-core#versioning), [cvat-data](https://github.com/opencv/cvat/tree/develop/cvat-data#versioning) and [cvat-ui](https://github.com/opencv/cvat/tree/develop/cvat-ui#versioning)) ### License - [ ] I submit _my code changes_ under the same [MIT License]( https://github.com/opencv/cvat/blob/develop/LICENSE) that covers the project. Feel free to contact the maintainers if that's a concern.
The job spends about a minute downloading and loading the CVAT server image, but I don't think it's used at all.
v1 of this action produces several deprecation warnings, which should hopefully be fixed in the most recent version. I don't think v2 has any problems, but I might as well bump it. For example: https://github.com/opencv/cvat/actions/runs/6624722303
) This would help users who don't want or need the complexity of Kubernetes, but would still like to use an external database. With Docker Compose, you can initialize a secret from an environment variable, but you can't load a secret _into_ an environment variable. So in order to be able to read the DB password from a secret, I had to introduce a new `CVAT_POSTGRES_PASSWORD_FILE` variable.
Hello CVAT friends! 👋😃 This PR introduces [Regal](https://github.com/styrainc/regal)) for linting the Rego included in this project. The policy code here is generally in a really good shape, so the linter did not have too much to do. Good work on that! Violations of a few rules were fixed as part of this PR, as they do not change the semantics of evaluation: * [line-length](https://docs.styra.com/regal/rules/style/line-length) * [unconditional-assignment](https://docs.styra.com/regal/rules/style/unconditional-assignment) * [use-assignment-operator](https://docs.styra.com/regal/rules/style/use-assignment-operator) A few other ones were ignored using Regal's configuration file. Whether some of them should be fixed in the future I'll leave up to the project's maintainers. I've also added Regal as a build workflow, along with some documentation. Let me know if I missed anything! Signed-off-by: Anders Eknert <anders@styra.com>
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
- Added videos to Cloud Storages - Updated wording in Cloud Storages - Updated data format for MOT Import
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
Try to fix the issue described in cart 322 ``` File \"/opt/venv/lib/python3.10/site-packages/botocore/session.py\", line 941, in get_component\n del self._deferred[name]\nKeyError: 'endpoint_resolver'\n","status_code":500 ``` Generally, this approach increases the time of creating clients but it does not affect us much because we create a client once or twice times for some operations (cloud storage creating, task creating with cloud storage data, retrieving a chunk, etc) ![image](https://github.com/opencv/cvat/assets/49038720/5adb4434-4d05-4882-b70c-ea760852b367) https://boto3.amazonaws.com/v1/documentation/api/latest/guide/resources.html#multithreading-or-multiprocessing-with-resources https://boto3.amazonaws.com/v1/documentation/api/latest/guide/session.html#multithreading-or-multiprocessing-with-sessions Co-authored-by: Andrey Zhavoronkov <andrey@cvat.ai>
This PR contains REST API tests for #6943
This PR speeds up the preparation of chunks by: 1. loading images once instead of twice in each writer, 2. as well as by allowing simultaneous preparation of more than 1 chunk using multithreading. This allows to reduce the time for preparation of chunks for 4895 images from 0:04:36 to 0:01:20 in case of preparation of 3 chunks in parallel and 0:02:46 in case of 1 chunk in my environment. Co-authored-by: Maria Khrustaleva <maya17grd@gmail.com>
…on (#7073) There is a couple of UX bugs in invite user to organization feature. This pr fixes: - Email is auto-verified after accepting invitation - Stuff can view unaccepted invitations - Stuff can edit unaccepted memberships - User email is now used as username
cvat-bot
bot
requested review from
azhavoro,
bsekachev,
mdacoca,
SpecLad,
Marishka17 and
nmanovic
as code owners
November 3, 2023 15:58
Codecov Report
@@ Coverage Diff @@
## master #7094 +/- ##
==========================================
+ Coverage 82.34% 82.41% +0.06%
==========================================
Files 361 361
Lines 39178 39310 +132
Branches 3585 3591 +6
==========================================
+ Hits 32261 32396 +135
+ Misses 6917 6914 -3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Support for default bucket prefix (Add support for default bucket prefix and ability to search for files #6943)
Search for cloud storage and share files (Add support for default bucket prefix and ability to search for files #6943)
Ability to limit one user to one task at a time (Add ability to limit one user to one task at a time #6975)
Support for using an external database in a Docker Compose-based deployment (Support running CVAT with an external database via Docker Compose #7055)
Changed
Migrated to rq 1.15.1 (Add ability to limit one user to one task at a time #6975)
Compressed sequental
change:frame
events into one (CompresschangeFrame
events #7048)Create a local session for AWS S3 client instead of using the default global one ([AWS S3] Use local session #7067)
Improved performance of chunk preparation when creating tasks (Chunk preparation optimization #7081)
Fixed
Race condition in a task data upload request, which may lead to problems with task creation in some specific cases, such as multiple identical data requests at the same time (Race condition for the task data upload request #7025)
Bug with viewing dependent RQ jobs for downloading resources from cloud storage when file path contains sub-directories. This is relevant for admins that can view detailed information about RQ queues. (Add ability to limit one user to one task at a time #6975)
OpenCV.js memory leak with TrackerMIL (TrackerMIL optimizations #7032)
Can't deploy detectron serverless function (Fixed: module 'PIL.Image' has no attribute 'LINEAR' #7047)
A mask becomes visible even if hidden after changing opacity level (Fixed: a mask becomes visible even if hidden after changing opacity level #7060)
There is no switcher to personal workspace if an organization request failed (Added error handling if organizations request is failed #7063)