-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compress changeFrame
events
#7048
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmanovic
reviewed
Oct 24, 2023
Codecov Report
@@ Coverage Diff @@
## develop #7048 +/- ##
===========================================
+ Coverage 82.33% 82.34% +0.01%
===========================================
Files 361 361
Lines 39213 39275 +62
Branches 3585 3591 +6
===========================================
+ Hits 32286 32341 +55
- Misses 6927 6934 +7
|
bsekachev
reviewed
Oct 25, 2023
bsekachev
reviewed
Oct 26, 2023
bsekachev
reviewed
Oct 30, 2023
bsekachev
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
We have too many event records of
changeFrame
andzoomImage
events. They are not really informative. This pr compresseschangeFrame
events and increases ignore events timeoutsHow has this been tested?
Checklist
develop
branch[] I have updated the documentation accordingly[ ] I have added tests to cover my changes(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.