Added error handling if organizations request is failed #7063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsekachev
changed the title
bsekachev
commented
Oct 26, 2023
| @@ -67,7 +67,7 @@ class OrganizationViewSet(viewsets.GenericViewSet, | |||
| PartialUpdateModelMixin, | |||
| ): | |||
| queryset = Organization.objects.select_related('owner').all() | |||
| search_fields = ('name', 'owner') | |||
| search_fields = ('name', 'owner', 'slug') | |||
There was a problem hiding this comment.
name may be empty. It makes it impossible to find some organizations via search query
Codecov Report
@@ Coverage Diff @@
## develop #7063 +/- ##
===========================================
- Coverage 82.34% 82.30% -0.05%
===========================================
Files 361 361
Lines 39222 39222
Branches 3588 3588
===========================================
- Hits 32298 32281 -17
- Misses 6924 6941 +17
|
nmanovic
reviewed
Oct 26, 2023
changelog.d/20231026_141231_sekachev.bs_additional_org_receive_check.md
Outdated
Show resolved
Hide resolved
nmanovic
approved these changes
Oct 30, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
How has this been tested?
Checklist
developbranch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.