Support running CVAT with an external database via Docker Compose #7055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Docker Compose, you can initialize a secret from an environment variable, but you can't load a secret _into_ an environment variable. So in order to be able to read the DB password from a secret, I had to introduce a new `CVAT_DB_PASSWORD_FILE` variable.
SpecLad
force-pushed
the
docker-compose-external-db
branch
2 times, most recently
from
13f1f7e to
25e4ce6
Compare
SpecLad
requested review from
azhavoro,
mdacoca,
Marishka17 and
nmanovic
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #7055 +/- ##
===========================================
- Coverage 82.33% 82.29% -0.05%
===========================================
Files 361 361
Lines 39213 39213
Branches 3585 3585
===========================================
- Hits 32286 32270 -16
- Misses 6927 6943 +16
|
nmanovic
approved these changes
Oct 26, 2023
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
This would help users who don't want or need the complexity of Kubernetes, but would still like to use an external database.
With Docker Compose, you can initialize a secret from an environment variable, but you can't load a secret into an environment variable. So in order to be able to read the DB password from a secret, I had to introduce a new
CVAT_POSTGRES_PASSWORD_FILEvariable.How has this been tested?
Manual testing.
Checklist
developbranch[ ] I have added tests to cover my changes[ ] I have linked related issues (see GitHub docs)[ ] I have increased versions of npm packages if it is necessary(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.