[AWS S3] Use local session #7067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #7067 +/- ##
===========================================
+ Coverage 82.31% 82.35% +0.03%
===========================================
Files 361 361
Lines 39263 39264 +1
Branches 3588 3588
===========================================
+ Hits 32321 32336 +15
+ Misses 6942 6928 -14
|
azhavoro
reviewed
Oct 30, 2023
Co-authored-by: Andrey Zhavoronkov <andrey@cvat.ai>
azhavoro
approved these changes
Oct 31, 2023
|
Please add changelog |
…ttps://github.com/opencv/cvat into mk/fix_parallel_downloading_of_cloud_storage_files
nmanovic
deleted the
mk/fix_parallel_downloading_of_cloud_storage_files
branch
Merged
bsekachev
pushed a commit
that referenced
this pull request
Nov 6, 2023
Try to fix the issue described in cart 322 ``` File \"/opt/venv/lib/python3.10/site-packages/botocore/session.py\", line 941, in get_component\n del self._deferred[name]\nKeyError: 'endpoint_resolver'\n","status_code":500 ``` Generally, this approach increases the time of creating clients but it does not affect us much because we create a client once or twice times for some operations (cloud storage creating, task creating with cloud storage data, retrieving a chunk, etc)  https://boto3.amazonaws.com/v1/documentation/api/latest/guide/resources.html#multithreading-or-multiprocessing-with-resources https://boto3.amazonaws.com/v1/documentation/api/latest/guide/session.html#multithreading-or-multiprocessing-with-sessions Co-authored-by: Andrey Zhavoronkov <andrey@cvat.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Try to fix the issue described in cart 322
Generally, this approach increases the time of creating clients but it does not affect us much because we create a client once or twice times for some operations (cloud storage creating, task creating with cloud storage data, retrieving a chunk, etc)
https://boto3.amazonaws.com/v1/documentation/api/latest/guide/resources.html#multithreading-or-multiprocessing-with-resources
https://boto3.amazonaws.com/v1/documentation/api/latest/guide/session.html#multithreading-or-multiprocessing-with-sessions
How has this been tested?
Checklist
developbranch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.