Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GT jobs creation #7126

Merged
merged 9 commits into from
Nov 28, 2023
Merged

Fix GT jobs creation #7126

merged 9 commits into from
Nov 28, 2023

Conversation

zhiltsov-max
Copy link
Contributor

Motivation and context

Ported from #6367

  • Fixed gt job creation for the whole task size
  • Fixed invalid chunk writing for GT jobs

How has this been tested?

Unit tests

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Merging #7126 (c389625) into develop (bd27827) will decrease coverage by 0.04%.
The diff coverage is 80.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7126      +/-   ##
===========================================
- Coverage    81.50%   81.46%   -0.04%     
===========================================
  Files          364      364              
  Lines        39881    39883       +2     
  Branches      3702     3702              
===========================================
- Hits         32505    32492      -13     
- Misses        7376     7391      +15     
Components Coverage Δ
cvat-ui 75.47% <ø> (-0.08%) ⬇️
cvat-server 87.09% <80.00%> (+<0.01%) ⬆️

@zhiltsov-max zhiltsov-max requested review from SpecLad and removed request for azhavoro and Marishka17 November 28, 2023 08:32
changelog.d/20231110_183941_mzhiltsov_fix_gt_jobs.md Outdated Show resolved Hide resolved

- Ground Truth job creation for the whole task size
(<https://github.com/opencv/cvat/pull/7126>)
- Incorrect Ground Truth chunks saving
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add any more detail here (e.g. how it was incorrect)?

@zhiltsov-max zhiltsov-max merged commit 81da411 into develop Nov 28, 2023
34 checks passed
@zhiltsov-max zhiltsov-max deleted the zm/fix-gt-jobs branch November 28, 2023 14:44
@cvat-bot cvat-bot bot mentioned this pull request Dec 11, 2023
amjadsaadeh pushed a commit to amjadsaadeh/cvat that referenced this pull request Dec 14, 2023
- Fixed gt job creation for the whole task size
- Fixed invalid chunk writing for GT jobs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants