Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2.9.2 #7252

Merged
merged 35 commits into from
Dec 11, 2023
Merged

Release v2.9.2 #7252

merged 35 commits into from
Dec 11, 2023

Conversation

cvat-bot[bot]
Copy link
Contributor

@cvat-bot cvat-bot bot commented Dec 11, 2023

Added

Changed

Fixed

Marishka17 and others added 30 commits November 23, 2023 15:25
Newer hugo/docsy versions will allow to use several new features, such as tab
groups and tags.

- Updated Docsy to v0.7.1
- Updated Hugo to v0.110.0
- Fixed broken layout in the footer
- Removed unnecessary breadcrumbs on the main page
- Fixed some links in the footer
- Updated the build pipeline to build both old and new releases
correctly
- Added VS Code tasks for docs build steps
- Now only the visible subset of the points is matched for both
  skeletons (previously, the GT skeleton visibility was used)
  This conforms with the overall IoU (or accuracy-based) approach to the
  quality metrics, used in other comparisons.

- Added protection from invalid numbers in the distance matching
  function to avoid similar problems with other annotations

- Updated python test docs about assets updating
- Fixed gt job creation for the whole task size
- Fixed invalid chunk writing for GT jobs
…ed (#7184)

This PR is complementary to #7132. 

#7132 updated ingress templates to work with `traefik.enabled=false` and
`ingress.enabled=true` values.

However the templates in `templates/analytics/middlewares` path lead to
creation of resources of kind `Middleware`, which is a Traefik CRD. Helm
install fails if Traefik is not installed on the cluster.

Changing the top-level conditional from `ingress.enabled` to
`traefik.enabled` solves the issue.
This PR resolves 2 issues related to rq jobs:

1. In some scenarios it is possible to reach a situation when `X2` rq
   job depends on `X1` -> running `X1` job is moved to FailedJobRegistry
   and not deleted -> user creates one more `X1` job that is enqueued after
   `X2` execution. It was possible due to the second issue when a user
   tried to export annotations for task 1, then for task 2, and after
   restarting the worker container user tried again to export annotations
   for task 1. (cyclic dependence)

2. Looks like in rq implementation rq jobs that depend on `X` job will
   never be enqueued when `X` is moved to FailedJobRegistry due to
   AbandonedJobError. I've submitted the
   [issue](rq/rq#2006) to the rq repository.
- Fixed a 500 error for supervisors and workers when they tried to list settings in an org context
- Added possible 403 and 404 errors for the task filter
This PR contains REST API tests for
#6801
Fix exceptions with 500 code, like this in our logging system: 
```
Error: KeyError: 'duration'

Error count: 131

Stack:
Traceback (most recent call last):
File "/opt/venv/lib/python3.10/site-packages/rest_framework/views.py", line 506, in dispatch
response = handler(request, *args, **kwargs)
File "/home/django/cvat/apps/events/views.py", line 32, in create
serializer.is_valid(raise_exception=True)
File "/opt/venv/lib/python3.10/site-packages/rest_framework/serializers.py", line 227, in is_valid
self._validated_data = self.run_validation(self.initial_data)
File "/opt/venv/lib/python3.10/site-packages/rest_framework/serializers.py", line 426, in run_validation
value = self.to_internal_value(data)
File "/home/django/cvat/apps/events/serializers.py", line 59, in to_internal_value
event_duration += datetime.timedelta(milliseconds=event["duration"])
KeyError: 'duration'
```
This should help reduce breakage if a user hits an API rate limit.
SpecLad and others added 5 commits December 8, 2023 17:37
Having both CPU and GPU images use the same image name and tag is
confusing, since you can't tell which one you have on your system
without deep inspection.
<!-- Raise an issue to propose your change
(https://github.com/opencv/cvat/issues).
It helps to avoid duplication of efforts from multiple independent
contributors.
Discuss your ideas with maintainers to be sure that changes will be
approved and merged.
Read the [Contribution
guide](https://opencv.github.io/cvat/docs/contributing/). -->

<!-- Provide a general summary of your changes in the Title above -->

### Motivation and context
<!-- Why is this change required? What problem does it solve? If it
fixes an open
issue, please link to the issue here. Describe your changes in detail,
add
screenshots. -->
That KeyDB version turned out rather unstable in practice, with multiple
crashes and freezes observed in production.

Resolved #7238

This reverts commit 118cc72.

### How has this been tested?
<!-- Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc. -->

### Checklist
<!-- Go over all the following points, and put an `x` in all the boxes
that apply.
If an item isn't applicable for some reason, then ~~explicitly
strikethrough~~ the whole
line. If you don't do that, GitHub will show incorrect progress for the
pull request.
If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [x] I submit my changes into the `develop` branch
- [ ] I have created a changelog fragment <!-- see top comment in
CHANGELOG.md -->
- ~~[ ] I have updated the documentation accordingly~~
- ~~[ ] I have added tests to cover my changes~~
- ~~[ ] I have linked related issues (see [GitHub docs](

https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))~~
- ~~[ ] I have increased versions of npm packages if it is necessary

([cvat-canvas](https://github.com/opencv/cvat/tree/develop/cvat-canvas#versioning),

[cvat-core](https://github.com/opencv/cvat/tree/develop/cvat-core#versioning),

[cvat-data](https://github.com/opencv/cvat/tree/develop/cvat-data#versioning)
and

[cvat-ui](https://github.com/opencv/cvat/tree/develop/cvat-ui#versioning))~~

### License

- [x] I submit _my code changes_ under the same [MIT License](
https://github.com/opencv/cvat/blob/develop/LICENSE) that covers the
project.
  Feel free to contact the maintainers if that's a concern.
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Merging #7252 (6263ba1) into master (45d23d4) will increase coverage by 0.35%.
Report is 5 commits behind head on master.
The diff coverage is 70.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7252      +/-   ##
==========================================
+ Coverage   81.44%   81.79%   +0.35%     
==========================================
  Files         364      367       +3     
  Lines       39882    39374     -508     
  Branches     3702     3644      -58     
==========================================
- Hits        32481    32206     -275     
+ Misses       7401     7168     -233     
Components Coverage Δ
cvat-ui 75.98% <68.71%> (+0.48%) ⬆️
cvat-server 87.08% <74.28%> (+0.06%) ⬆️

@cvat-bot cvat-bot bot merged commit efd932d into master Dec 11, 2023
31 checks passed
@cvat-bot cvat-bot bot deleted the release-2.9.2 branch December 11, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.