-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v2.9.2 #7252
Merged
Merged
Release v2.9.2 #7252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update develop after v2.9.0
Newer hugo/docsy versions will allow to use several new features, such as tab groups and tags. - Updated Docsy to v0.7.1 - Updated Hugo to v0.110.0 - Fixed broken layout in the footer - Removed unnecessary breadcrumbs on the main page - Fixed some links in the footer - Updated the build pipeline to build both old and new releases correctly - Added VS Code tasks for docs build steps
- Now only the visible subset of the points is matched for both skeletons (previously, the GT skeleton visibility was used) This conforms with the overall IoU (or accuracy-based) approach to the quality metrics, used in other comparisons. - Added protection from invalid numbers in the distance matching function to avoid similar problems with other annotations - Updated python test docs about assets updating
- Fixed gt job creation for the whole task size - Fixed invalid chunk writing for GT jobs
…ed (#7184) This PR is complementary to #7132. #7132 updated ingress templates to work with `traefik.enabled=false` and `ingress.enabled=true` values. However the templates in `templates/analytics/middlewares` path lead to creation of resources of kind `Middleware`, which is a Traefik CRD. Helm install fails if Traefik is not installed on the cluster. Changing the top-level conditional from `ingress.enabled` to `traefik.enabled` solves the issue.
This PR resolves 2 issues related to rq jobs: 1. In some scenarios it is possible to reach a situation when `X2` rq job depends on `X1` -> running `X1` job is moved to FailedJobRegistry and not deleted -> user creates one more `X1` job that is enqueued after `X2` execution. It was possible due to the second issue when a user tried to export annotations for task 1, then for task 2, and after restarting the worker container user tried again to export annotations for task 1. (cyclic dependence) 2. Looks like in rq implementation rq jobs that depend on `X` job will never be enqueued when `X` is moved to FailedJobRegistry due to AbandonedJobError. I've submitted the [issue](rq/rq#2006) to the rq repository.
Fixes #7182 by including pre-release versions as explained in the [helm docs](https://helm.sh/docs/chart_template_guide/function_list/#working-with-prerelease-versions).
- Fixed a 500 error for supervisors and workers when they tried to list settings in an org context - Added possible 403 and 404 errors for the task filter
This PR contains REST API tests for #6801
Since rq Job.fetch_many (https://github.com/rq/rq/blob/d11094af95188c197a5e11b1c4fa05b000485370/rq/job.py#L604) can return `None` we must explicitly check that job exists.
Fix exceptions with 500 code, like this in our logging system: ``` Error: KeyError: 'duration' Error count: 131 Stack: Traceback (most recent call last): File "/opt/venv/lib/python3.10/site-packages/rest_framework/views.py", line 506, in dispatch response = handler(request, *args, **kwargs) File "/home/django/cvat/apps/events/views.py", line 32, in create serializer.is_valid(raise_exception=True) File "/opt/venv/lib/python3.10/site-packages/rest_framework/serializers.py", line 227, in is_valid self._validated_data = self.run_validation(self.initial_data) File "/opt/venv/lib/python3.10/site-packages/rest_framework/serializers.py", line 426, in run_validation value = self.to_internal_value(data) File "/home/django/cvat/apps/events/serializers.py", line 59, in to_internal_value event_duration += datetime.timedelta(milliseconds=event["duration"]) KeyError: 'duration' ```
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
This should help reduce breakage if a user hits an API rate limit.
Having both CPU and GPU images use the same image name and tag is confusing, since you can't tell which one you have on your system without deep inspection.
<!-- Raise an issue to propose your change (https://github.com/opencv/cvat/issues). It helps to avoid duplication of efforts from multiple independent contributors. Discuss your ideas with maintainers to be sure that changes will be approved and merged. Read the [Contribution guide](https://opencv.github.io/cvat/docs/contributing/). --> <!-- Provide a general summary of your changes in the Title above --> ### Motivation and context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. Describe your changes in detail, add screenshots. --> That KeyDB version turned out rather unstable in practice, with multiple crashes and freezes observed in production. Resolved #7238 This reverts commit 118cc72. ### How has this been tested? <!-- Please describe in detail how you tested your changes. Include details of your testing environment, and the tests you ran to see how your change affects other areas of the code, etc. --> ### Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. If an item isn't applicable for some reason, then ~~explicitly strikethrough~~ the whole line. If you don't do that, GitHub will show incorrect progress for the pull request. If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] I submit my changes into the `develop` branch - [ ] I have created a changelog fragment <!-- see top comment in CHANGELOG.md --> - ~~[ ] I have updated the documentation accordingly~~ - ~~[ ] I have added tests to cover my changes~~ - ~~[ ] I have linked related issues (see [GitHub docs]( https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))~~ - ~~[ ] I have increased versions of npm packages if it is necessary ([cvat-canvas](https://github.com/opencv/cvat/tree/develop/cvat-canvas#versioning), [cvat-core](https://github.com/opencv/cvat/tree/develop/cvat-core#versioning), [cvat-data](https://github.com/opencv/cvat/tree/develop/cvat-data#versioning) and [cvat-ui](https://github.com/opencv/cvat/tree/develop/cvat-ui#versioning))~~ ### License - [x] I submit _my code changes_ under the same [MIT License]( https://github.com/opencv/cvat/blob/develop/LICENSE) that covers the project. Feel free to contact the maintainers if that's a concern.
cvat-bot
bot
requested review from
azhavoro,
bsekachev,
mdacoca,
SpecLad,
Marishka17 and
nmanovic
as code owners
December 11, 2023 16:49
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7252 +/- ##
==========================================
+ Coverage 81.44% 81.79% +0.35%
==========================================
Files 364 367 +3
Lines 39882 39374 -508
Branches 3702 3644 -58
==========================================
- Hits 32481 32206 -275
+ Misses 7401 7168 -233
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Introduced CVAT actions. Actions allow performing different predefined scenarios on annotations automatically (e.g. shape converters) (Introduced annotations actions #7172)
The UI will now retry requests that were rejected due to rate limiting (cvat-core: retry HTTP requests if a 429 status is returned #7216)
Changed
Update nvidia/cuda image version from 11.7.0 to 11.7.1 in transt serverless function. (Bump cuda image version from 11.7.0 to 11.7.1 #7124)
[Helm] Allow pre-release versions in kubernetes requirement to include AWS EKS versions ([Helm] Allow pre-release k8s versions to fix AWS EKS deployments #7183)
GPU versions of serverless functions now use the
latest-gpu
Docker tag rather thanlatest
(Use different tags for GPU versions of serverless functions #7215)[Compose, Helm] Downgraded KeyDB to 6.3.2 (Revert "Update keydb to 6.3.4 (#7118)" #7236)
Fixed
The GPU version of the YOLOv7 serverless function not actually using the GPU (YOLOv7: use the correct version of ONNX Runtime for GPU #6940)
It is now possible to create Ground Truth jobs containing all frames in the task (Fix GT jobs creation #7126)
Incorrect Ground Truth chunks saving (Fix GT jobs creation #7126)
Reset source/target storage if related cloud storage has been deleted (Reset source/target storage if related cloud storage has been deleted #6801)
Prevent possible cyclic dependencies when enqueuing a rq job when ONE_RUNNING_JOB_IN_QUEUE_PER_USER is used (Fix issues related to rq job dependencies #7139)
Enqueue deferred jobs when their dependencies are moved to the failed job registry due to AbandonedJobError (Fix issues related to rq job dependencies #7139)
Reduce the number of requests to the server for task details (Reduce the number of requests for task details #7167)
Shape settings opacity and selected opacity reset on each frame change (Fix opacity reset #7186)
Server error in list quality settings API, when called in an org (Fix list GT settings permissions in an org #7190)
Incorrect handling of the hidden points in skeletons in quality comparisons (Fix hidden points in skeleton comparison in quality checks #7191)
[Helm] Fixed installing Traefik Middleware even if Traefik is disabled in the values ([Helm] Don't try to install Traefik Middleware when Traefik is disabled #7184)
Error code 500 when send
change:frame
event withoutduration
. (Added validation ofduration
field forchange:frame
#7211)Added workaround for corrupted cached chunks (Added workaround for corrupted zip chunks #7243, Recreate a chunk in case of UnpicklingError #7251)