Revert "Update keydb to 6.3.4 (#7118)" #7236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That KeyDB version turned out rather unstable in practice, with multiple crashes and freezes observed in production. This reverts commit 118cc72.
|
We have also been experiencing crashes and segfaults with KeyDB 6.3.4, thanks for the PR! |
2 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #7236 +/- ##
===========================================
- Coverage 81.54% 81.36% -0.19%
===========================================
Files 365 366 +1
Lines 39261 39357 +96
Branches 3631 3644 +13
===========================================
+ Hits 32016 32023 +7
- Misses 7245 7334 +89
|
nmanovic
reviewed
Dec 11, 2023
| @@ -249,7 +249,6 @@ keydb: | |||
| enabled: true | |||
| external: | |||
| host: 127.0.0.1 | |||
| imageTag: x86_64_v6.3.4 | |||
There was a problem hiding this comment.
Should we specify x86_64_v6.3.2 explicitly? Even it is a default value, can it be changed by someone outside?
There was a problem hiding this comment.
Does it support Mac deployment (ARM arch)?
There was a problem hiding this comment.
Should we specify x86_64_v6.3.2 explicitly? Even it is a default value, can it be changed by someone outside?
It could be changed in either case, since all values in this file are overridable.
Does it support Mac deployment (ARM arch)?
I cannot verify this, not having a Mac myself, but I'm pretty sure that Docker on Mac uses VMs, so it can run either x86_64 or arm64 images.
But for the record, KeyDB has arm64 images too.
azhavoro
approved these changes
Dec 11, 2023
Merged
amjadsaadeh
pushed a commit
to amjadsaadeh/cvat
that referenced
this pull request
Dec 14, 2023
<!-- Raise an issue to propose your change (https://github.com/opencv/cvat/issues). It helps to avoid duplication of efforts from multiple independent contributors. Discuss your ideas with maintainers to be sure that changes will be approved and merged. Read the [Contribution guide](https://opencv.github.io/cvat/docs/contributing/). --> <!-- Provide a general summary of your changes in the Title above --> ### Motivation and context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. Describe your changes in detail, add screenshots. --> That KeyDB version turned out rather unstable in practice, with multiple crashes and freezes observed in production. Resolved cvat-ai#7238 This reverts commit 118cc72. ### How has this been tested? <!-- Please describe in detail how you tested your changes. Include details of your testing environment, and the tests you ran to see how your change affects other areas of the code, etc. --> ### Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. If an item isn't applicable for some reason, then ~~explicitly strikethrough~~ the whole line. If you don't do that, GitHub will show incorrect progress for the pull request. If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] I submit my changes into the `develop` branch - [ ] I have created a changelog fragment <!-- see top comment in CHANGELOG.md --> - ~~[ ] I have updated the documentation accordingly~~ - ~~[ ] I have added tests to cover my changes~~ - ~~[ ] I have linked related issues (see [GitHub docs]( https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))~~ - ~~[ ] I have increased versions of npm packages if it is necessary ([cvat-canvas](https://github.com/opencv/cvat/tree/develop/cvat-canvas#versioning), [cvat-core](https://github.com/opencv/cvat/tree/develop/cvat-core#versioning), [cvat-data](https://github.com/opencv/cvat/tree/develop/cvat-data#versioning) and [cvat-ui](https://github.com/opencv/cvat/tree/develop/cvat-ui#versioning))~~ ### License - [x] I submit _my code changes_ under the same [MIT License]( https://github.com/opencv/cvat/blob/develop/LICENSE) that covers the project. Feel free to contact the maintainers if that's a concern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
That KeyDB version turned out rather unstable in practice, with multiple crashes and freezes observed in production.
Resolved #7238
This reverts commit 118cc72.
How has this been tested?
Checklist
developbranch[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have linked related issues (see GitHub docs)[ ] I have increased versions of npm packages if it is necessary(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.