Fix hidden points in skeleton comparison in quality checks #7191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #7191 +/- ##
===========================================
- Coverage 81.48% 81.47% -0.01%
===========================================
Files 364 364
Lines 39877 39881 +4
Branches 3702 3702
===========================================
Hits 32494 32494
- Misses 7383 7387 +4
|
zhiltsov-max
requested review from
SpecLad
and removed request for
azhavoro and
Marishka17
SpecLad
reviewed
Nov 28, 2023
| @@ -0,0 +1,4 @@ | |||
| ### Fixed | |||
|
|
|||
| - Incorrect handling of the hidden points in skeletons in quality comparisons | |||
There was a problem hiding this comment.
AFAICS, the first change in quality_reports.py isn't related to skeletons, so it probably deserves another entry.
SpecLad
approved these changes
Nov 28, 2023
Merged
amjadsaadeh
pushed a commit
to amjadsaadeh/cvat
that referenced
this pull request
Dec 14, 2023
) - Now only the visible subset of the points is matched for both skeletons (previously, the GT skeleton visibility was used) This conforms with the overall IoU (or accuracy-based) approach to the quality metrics, used in other comparisons. - Added protection from invalid numbers in the distance matching function to avoid similar problems with other annotations - Updated python test docs about assets updating
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Now only the visible subset of the points is matched for both skeletons (previously, the GT skeleton visibility was used)
This conforms with the overall IoU (or accuracy-based) approach to the quality metrics, used in other comparisons.
Added protection from invalid numbers in the distance matching function to avoid similar problems with other annotations
Updated python test docs about assets updating
How has this been tested?
Unit test
Checklist
developbranch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.