Use different tags for GPU versions of serverless functions #7215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having both CPU and GPU images use the same image name and tag is confusing.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #7215 +/- ##
===========================================
+ Coverage 81.47% 81.54% +0.06%
===========================================
Files 365 365
Lines 39923 39257 -666
Branches 3703 3631 -72
===========================================
- Hits 32528 32012 -516
+ Misses 7395 7245 -150
|
bsekachev
reviewed
Dec 4, 2023
bsekachev
approved these changes
Dec 8, 2023
Merged
amjadsaadeh
pushed a commit
to amjadsaadeh/cvat
that referenced
this pull request
Dec 14, 2023
…7215) Having both CPU and GPU images use the same image name and tag is confusing, since you can't tell which one you have on your system without deep inspection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Having both CPU and GPU images use the same image name and tag is confusing, since you can't tell which one you have on your system without deep inspection.
How has this been tested?
Manual testing.
Checklist
developbranch[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have linked related issues (see GitHub docs)[ ] I have increased versions of npm packages if it is necessary(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.