Added validation of duration field for change:frame
#7211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsekachev
commented
Dec 1, 2023
bsekachev
changed the title
duration field for change:frame
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #7211 +/- ##
===========================================
- Coverage 81.35% 81.33% -0.02%
===========================================
Files 366 366
Lines 39357 39358 +1
Branches 3644 3645 +1
===========================================
- Hits 32017 32010 -7
- Misses 7340 7348 +8
|
SpecLad
reviewed
Dec 6, 2023
cvat/apps/events/serializers.py
Outdated
| def validate(self, data): | ||
| for event in data["events"]: | ||
| if event["scope"] in self._COLLAPSED_EVENT_SCOPES: | ||
| if not isinstance(event.get("duration"), int): |
There was a problem hiding this comment.
Something seems wrong here. EventSerializer.duration has a default, so it should not be possible for it to be anything other than an int:
>>> s = EventSerializer(data={'scope': 'change:frame', 'timestamp': '2023-12-06T10:47:14.085178'})
>>> s.is_valid()
True
>>> s.validated_data['duration']
0Are we skipping EventSerializer's validation somehow?
There was a problem hiding this comment.
hmm.. yes, it has
default implementation for validate in Serializer class is:
def validate(self, attrs):
return attrs
There was a problem hiding this comment.
validate only handles custom validation, so it makes sense that it does nothing by default. The per-field validation is supposed to happen somewhere inside is_valid.
There was a problem hiding this comment.
So, perhaps we only need to keep default value in to_internal_value
Check is not necessary.
There was a problem hiding this comment.
Updated, now it uses default value from nested class
bsekachev
changed the title
duration field for change:frameduration field for change:frame
bsekachev
changed the title
duration field for change:frameduration field for change:frame
SpecLad
approved these changes
Dec 7, 2023
Merged
amjadsaadeh
pushed a commit
to amjadsaadeh/cvat
that referenced
this pull request
Dec 14, 2023
Fix exceptions with 500 code, like this in our logging system: ``` Error: KeyError: 'duration' Error count: 131 Stack: Traceback (most recent call last): File "/opt/venv/lib/python3.10/site-packages/rest_framework/views.py", line 506, in dispatch response = handler(request, *args, **kwargs) File "/home/django/cvat/apps/events/views.py", line 32, in create serializer.is_valid(raise_exception=True) File "/opt/venv/lib/python3.10/site-packages/rest_framework/serializers.py", line 227, in is_valid self._validated_data = self.run_validation(self.initial_data) File "/opt/venv/lib/python3.10/site-packages/rest_framework/serializers.py", line 426, in run_validation value = self.to_internal_value(data) File "/home/django/cvat/apps/events/serializers.py", line 59, in to_internal_value event_duration += datetime.timedelta(milliseconds=event["duration"]) KeyError: 'duration' ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Fix exceptions with 500 code, like this in our logging system:
How has this been tested?
Checklist
developbranch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.