Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[regression] 0.9.6 crashes when clicking "Example" as a first action #95

Closed
okias opened this issue Jan 7, 2024 · 11 comments · Fixed by #97 or #103
Closed

[regression] 0.9.6 crashes when clicking "Example" as a first action #95

okias opened this issue Jan 7, 2024 · 11 comments · Fixed by #97 or #103
Assignees
@jdupak
Labels
bug Something isn't working

Comments

@okias
Copy link
Contributor

okias commented Jan 7, 2024 

$ flatpak install --user https://dl.flathub.org/build-repo/74697/cz.cvut.edu.comparch.qtrvsim.flatpakref
$ flatpak run cz.cvut.edu.comparch.qtrvsim

When you open the application and first action is clicking "Example" button, application silently crashes.

Works for 0.9.5 or when you press something else before pressing "Example" button
@jdupak
Copy link
Collaborator

jdupak commented Jan 24, 2024 via email

@Arielfoever
Copy link
Contributor

Arielfoever commented Jan 26, 2024 •
edited
Loading

With the help of bitect, I found out that the commit causing the problem is 16c78c1 .

Bitect details 
16c78c16948799a008b47569ea53989623c33e1f is the first bad commit
commit 16c78c16948799a008b47569ea53989623c33e1f
Author: Jakub Dupak <dev@jakubdupak.com>
Date:   Sun Jul 16 23:40:44 2023 +0200

    GUI: split central widget tabs to coreview and editor

 src/gui/mainwindow/mainwindow.cpp | 17 +++++++++++------
 src/gui/mainwindow/mainwindow.h   |  3 ++-
 2 files changed, 13 insertions(+), 7 deletions(-)

I have checked 3dcd696 whose everything's fine.

I have checked 16c78c1 which causes an error during building process.

Compile Log 
PS E:\56\qtrvsim> D:\CMake\bin\cmake.exe E:\56\qtrvsim -DCMAKE_BUILD_TYPE=Release -DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++ -DCMAKE_C_COMPILER_LAUNCHER="E:\ccache-4.9-windows-x86_64\ccache.exe" -DCMAKE_CXX_COMPILER_LAUNCHER="E:\ccache-4.9-windows-x86_64\ccache.exe" -DFORCE_COLORED_OUTPUT=true -G "MinGW Makefiles"
-- Debug prints globally suppressed.
-- Could NOT find LibElf (missing: LIBELF_LIBRARY LIBELF_INCLUDE_DIR)
-- Using local libelf fallback.
-- Qt5 version: 5.12.9
-- Qt5 print support: 1
-- Configuring done (0.2s)
-- Generating done (0.2s)
-- Build files have been written to: E:/56/qtrvsim
PS E:\56\qtrvsim> D:\CMake\bin\cmake.exe --build . -j24
[  2%] Automatic MOC for target mulh64_test
[  3%] Automatic MOC and UIC for target svgscene
[  3%] Automatic MOC for target registers_test
[  5%] [  5%] Automatic MOC for target alu_test
Automatic MOC for target memory_test
[  5%] Automatic MOC for target assembler
[  6%] [  6%] Automatic MOC for target cache_test
Automatic MOC for target os_emulation
[ 30%] Built target libelf
[ 30%] Built target svgscene_autogen
[ 30%] Built target instruction_test_autogen
[ 30%] Built target mulh64_test_autogen
[ 30%] Built target alu_test_autogen
[ 30%] Built target registers_test_autogen
[ 30%] Built target memory_test_autogen
[ 30%] Built target cache_test_autogen
[ 30%] Built target assembler_autogen
[ 30%] Built target os_emulation_autogen
[ 31%] Automatic MOC for target core_test
[ 31%] Automatic MOC for target machine
[ 32%] Automatic MOC for target program_loader_test
[ 32%] Built target core_test_autogen
[ 32%] Built target machine_autogen
[ 32%] Built target program_loader_test_autogen
[ 33%] Built target mulh64_test
[ 34%] Built target os_emulation
[ 36%] Built target assembler
[ 41%] Built target svgscene
[ 42%] Built target alu_test
[ 44%] Built target registers_test
[ 47%] Built target memory_test
[ 53%] Built target cache_test
[ 55%] Built target instruction_test
[ 58%] Built target program_loader_test
[ 68%] Built target machine
[ 74%] Built target core_test
[ 75%] Automatic MOC for target cli
[ 76%] Automatic MOC and UIC for target gui
[ 76%] Built target cli_autogen
[ 79%] Built target cli
[ 79%] Built target gui_autogen
[ 80%] Building CXX object src/gui/CMakeFiles/gui.dir/gui_autogen/mocs_compilation.cpp.obj
[ 81%] Building CXX object src/gui/CMakeFiles/gui.dir/dialogs/new/newdialog.cpp.obj
[ 82%] Building CXX object src/gui/CMakeFiles/gui.dir/main.cpp.obj
[ 82%] Building CXX object src/gui/CMakeFiles/gui.dir/mainwindow/mainwindow.cpp.obj
[ 82%] Linking CXX executable ..\..\target\qtrvsim_gui.exe
[100%] Built target gui
PS E:\56\qtrvsim> D:\CMake\bin\cmake.exe E:\56\qtrvsim -DCMAKE_BUILD_TYPE=Release -DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++ -DCMAKE_C_COMPILER_LAUNCHER="E:\ccache-4.9-windows-x86_64\ccache.exe" -DCMAKE_CXX_COMPILER_LAUNCHER="E:\ccache-4.9-windows-x86_64\ccache.exe" -DFORCE_COLORED_OUTPUT=true -G "MinGW Makefiles"
-- Debug prints globally suppressed.
-- Could NOT find LibElf (missing: LIBELF_LIBRARY LIBELF_INCLUDE_DIR)
-- Using local libelf fallback.
-- Qt5 version: 5.12.9
-- Qt5 print support: 1
-- Configuring done (0.2s)
-- Generating done (0.2s)
-- Build files have been written to: E:/56/qtrvsim
PS E:\56\qtrvsim> D:\CMake\bin\cmake.exe --build . -j24
[  1%] Automatic MOC and UIC for target svgscene
[  2%] Automatic MOC for target mulh64_test
[  2%] Automatic MOC for target registers_test
[  3%] Automatic MOC for target memory_test
[  4%] Automatic MOC for target alu_test
[  4%] Automatic MOC for target assembler
[  4%] Automatic MOC for target cache_test
[  5%] Automatic MOC for target instruction_test
[  6%] Automatic MOC for target os_emulation
[ 30%] Built target libelf
[ 30%] Built target svgscene_autogen
[ 30%] Built target mulh64_test_autogen
[ 30%] Built target registers_test_autogen
[ 30%] Built target memory_test_autogen
[ 30%] Built target alu_test_autogen
[ 30%] Built target cache_test_autogen
[ 30%] Built target instruction_test_autogen
[ 30%] Built target assembler_autogen
[ 30%] Built target os_emulation_autogen
[ 30%] Automatic MOC for target machine
[ 31%] Automatic MOC for target core_test
[ 32%] Automatic MOC for target program_loader_test
[ 32%] Built target machine_autogen
[ 32%] Built target program_loader_test_autogen
[ 32%] Built target core_test_autogen
[ 33%] Built target mulh64_test
[ 34%] Built target os_emulation
[ 35%] Built target alu_test
[ 40%] Built target svgscene
[ 42%] Built target registers_test
[ 44%] Built target assembler
[ 47%] Built target memory_test
[ 53%] Built target cache_test
[ 55%] Built target instruction_test
[ 58%] Built target program_loader_test
[ 68%] Built target machine
[ 74%] Built target core_test
[ 76%] [ 76%] Automatic MOC for target cli
Automatic MOC and UIC for target gui
[ 76%] Built target cli_autogen
[ 79%] Built target cli
[ 79%] Built target gui_autogen
[ 80%] Building CXX object src/gui/CMakeFiles/gui.dir/gui_autogen/mocs_compilation.cpp.obj
[ 81%] Building CXX object src/gui/CMakeFiles/gui.dir/dialogs/new/newdialog.cpp.obj
[ 82%] Building CXX object src/gui/CMakeFiles/gui.dir/main.cpp.obj
[ 82%] Building CXX object src/gui/CMakeFiles/gui.dir/mainwindow/mainwindow.cpp.obj
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp: In constructor 'MainWindow::MainWindow(QSettings*, QWidget*)':
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp:56:26: error: 'class HidingTabWidget' has no member named 'setTabVisibl
'; did you mean 'setVisible'?
     central_widget_tabs->setTabVisible(central_widget_tabs->indexOf(editor_tabs.data()), false);
                          ^~~~~~~~~~~~~
                          setVisible
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp:141:9: error: 'central_window' was not declared in this scope
         central_window.data(), &HidingTabWidget::currentChanged, this,
         ^~~~~~~~~~~~~~
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp:141:9: note: suggested alternative: 'centralWidget'
         central_window.data(), &HidingTabWidget::currentChanged, this,
         ^~~~~~~~~~~~~~
         centralWidget
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp: In member function 'void MainWindow::show_hide_coreview(bool)':
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp:180:13: error: 'central_window' was not declared in this scope
             central_window->removeTab(central_window->indexOf(coreview.data()));
             ^~~~~~~~~~~~~~
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp:180:13: note: suggested alternative: 'centralWidget'
             central_window->removeTab(central_window->indexOf(coreview.data()));
             ^~~~~~~~~~~~~~
             centralWidget
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp:194:5: error: 'central_window' was not declared in this scope
     central_window->insertTab(0, coreview.data(), "Core");
     ^~~~~~~~~~~~~~
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp:194:5: note: suggested alternative: 'centralWidget'
     central_window->insertTab(0, coreview.data(), "Core");
     ^~~~~~~~~~~~~~
     centralWidget
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp: In member function 'void MainWindow::create_core(const machine::MachineConfig&, bool, bool)':
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp:233:26: error: 'central_window' was not declared in this scope
     auto focused_index = central_window->currentIndex();
                          ^~~~~~~~~~~~~~
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp:233:26: note: suggested alternative: 'centralWidget'
     auto focused_index = central_window->currentIndex();
                          ^~~~~~~~~~~~~~
                          centralWidget
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp: In member function 'void MainWindow::save_exit_or_ignore(bool, const QStringList&)':
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp:472:26: error: 'central_window' was not declared in this scope
     if (save_unnamed && (central_window != nullptr)) {
                          ^~~~~~~~~~~~~~
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp:472:26: note: suggested alternative: 'centralWidget'
     if (save_unnamed && (central_window != nullptr)) {
                          ^~~~~~~~~~~~~~
                          centralWidget
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp: In member function 'void MainWindow::central_tab_changed(int)':
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp:560:23: error: 'central_window' was not declared in this scope
     QWidget *widget = central_window->widget(index);
                       ^~~~~~~~~~~~~~
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp:560:23: note: suggested alternative: 'centralWidget'
     QWidget *widget = central_window->widget(index);
                       ^~~~~~~~~~~~~~
                       centralWidget
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp: In member function 'void MainWindow::add_src_editor_to_tabs(SrcEditor*
':
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp:566:5: error: 'central_window' was not declared in this scope
     central_window->addTab(editor, editor->title());
     ^~~~~~~~~~~~~~
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp:566:5: note: suggested alternative: 'centralWidget'
     central_window->addTab(editor, editor->title());
     ^~~~~~~~~~~~~~
     centralWidget
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp: In member function 'void MainWindow::update_open_file_list()':
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp:573:10: error: 'central_window' was not declared in this scope
     if ((central_window == nullptr) || (settings == nullptr)) { return; }
          ^~~~~~~~~~~~~~
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp:573:10: note: suggested alternative: 'centralWidget'
     if ((central_window == nullptr) || (settings == nullptr)) { return; }
          ^~~~~~~~~~~~~~
          centralWidget
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp:574:25: error: 'central_window' was not declared in this scope
     for (int i = 0; i < central_window->count(); i++) {
                         ^~~~~~~~~~~~~~
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp:574:25: note: suggested alternative: 'centralWidget'
     for (int i = 0; i < central_window->count(); i++) {
                         ^~~~~~~~~~~~~~
                         centralWidget
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp: In member function 'bool MainWindow::modified_file_list(QStringList&, bool)':
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp:587:9: error: 'central_window' was not declared in this scope
     if (central_window == nullptr) { return false; }
         ^~~~~~~~~~~~~~
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp:587:9: note: suggested alternative: 'centralWidget'
     if (central_window == nullptr) { return false; }
         ^~~~~~~~~~~~~~
         centralWidget
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp:588:25: error: 'central_window' was not declared in this scope
     for (int i = 0; i < central_window->count(); i++) {
                         ^~~~~~~~~~~~~~
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp:588:25: note: suggested alternative: 'centralWidget'
     for (int i = 0; i < central_window->count(); i++) {
                         ^~~~~~~~~~~~~~
                         centralWidget
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp: In member function 'SrcEditor* MainWindow::source_editor_for_file(const QString&, bool)':
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp:611:9: error: 'central_window' was not declared in this scope
     if (central_window == nullptr) { return nullptr; }
         ^~~~~~~~~~~~~~
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp:611:9: note: suggested alternative: 'centralWidget'
     if (central_window == nullptr) { return nullptr; }
         ^~~~~~~~~~~~~~
         centralWidget
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp:614:25: error: 'central_window' was not declared in this scope
     for (int i = 0; i < central_window->count(); i++) {
                         ^~~~~~~~~~~~~~
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp:614:25: note: suggested alternative: 'centralWidget'
     for (int i = 0; i < central_window->count(); i++) {
                         ^~~~~~~~~~~~~~
                         centralWidget
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp: In member function 'void MainWindow::open_source()':
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp:652:17: error: 'central_window' was not declared in this scope
             if (central_window != nullptr) { central_window->setCurrentWidget(editor); }
                 ^~~~~~~~~~~~~~
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp:652:17: note: suggested alternative: 'centralWidget'
             if (central_window != nullptr) { central_window->setCurrentWidget(editor); }
                 ^~~~~~~~~~~~~~
                 centralWidget
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp: In member function 'void MainWindow::save_source_as()':
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp:687:15: error: 'central_window' was not declared in this scope
     int idx = central_window->indexOf(current_srceditor);
               ^~~~~~~~~~~~~~
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp:687:15: note: suggested alternative: 'centralWidget'
     int idx = central_window->indexOf(current_srceditor);
               ^~~~~~~~~~~~~~
               centralWidget
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp: In member function 'void MainWindow::src_editor_save_to(const QString&
':
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp:710:15: error: 'central_window' was not declared in this scope
     int idx = central_window->indexOf(current_srceditor);
               ^~~~~~~~~~~~~~
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp:710:15: note: suggested alternative: 'centralWidget'
     int idx = central_window->indexOf(current_srceditor);
               ^~~~~~~~~~~~~~
               centralWidget
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp: In member function 'void MainWindow::close_source()':
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp:770:15: error: 'central_window' was not declared in this scope
     int idx = central_window->indexOf(editor);
               ^~~~~~~~~~~~~~
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp:770:15: note: suggested alternative: 'centralWidget'
     int idx = central_window->indexOf(editor);
               ^~~~~~~~~~~~~~
               centralWidget
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp: In member function 'void MainWindow::message_selected(messagetype::Type, const QString&, int, int, const QString&, const QString&)':
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp:819:9: error: 'central_window' was not declared in this scope
     if (central_window != nullptr) { central_window->setCurrentWidget(editor); }
         ^~~~~~~~~~~~~~
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp:819:9: note: suggested alternative: 'centralWidget'
     if (central_window != nullptr) { central_window->setCurrentWidget(editor); }
         ^~~~~~~~~~~~~~
         centralWidget
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp: In member function 'virtual bool SimpleAsmWithEditorCheck::process_pragma(QStringList&, const QString&, int, QString*)':
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp:867:29: error: 'class MainWindow' has no member named 'central_window'; did you mean 'centralWidget'?
             && (mainwindow->central_window != nullptr) && (mainwindow->coreview != nullptr)) {
                             ^~~~~~~~~~~~~~
                             centralWidget
E:\56\qtrvsim\src\gui\mainwindow\mainwindow.cpp:868:25: error: 'class MainWindow' has no member named 'central_window'; did you mean 'centralWidget'?
             mainwindow->central_window->setCurrentWidget(mainwindow->coreview.data());
                         ^~~~~~~~~~~~~~
                         centralWidget
mingw32-make.exe[2]: *** [src\gui\CMakeFiles\gui.dir\build.make:477: src/gui/CMakeFiles/gui.dir/mainwindow/mainwindow.cpp.obj] Error 1
mingw32-make.exe[1]: *** [CMakeFiles\Makefile2:1068: src/gui/CMakeFiles/gui.dir/all] Error 2
mingw32-make.exe: *** [Makefile:145: all] Error 2

Environment Info

Configurations 
-- The C compiler identification is GNU 8.1.0
-- The CXX compiler identification is GNU 8.1.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: E:/mingw64/bin/gcc.exe - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: E:/mingw64/bin/g++.exe - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Debug prints globally suppressed.
-- Could NOT find LibElf (missing: LIBELF_LIBRARY LIBELF_INCLUDE_DIR)
-- Using local libelf fallback.
-- Qt5 version: 5.12.9
-- Qt5 print support: 1
-- Configuring done (1.6s)
-- Generating done (0.2s)
-- Build files have been written to: E:/56/qtrvsim

Qt 5.12.9 comes from Qt Downloads.

Compiler comes from mingw-w64.

@Arielfoever
Copy link
Contributor

Arielfoever commented Jan 26, 2024 •
edited
Loading

I confirmed that the issue was successfully reproduced on Window on 0.9.6 .

After clicking the "Example" button for a while, the program crashes with nothing.

@okias
Copy link
Contributor Author

okias commented Jan 26, 2024

Sure, it's building again. flathub/cz.cvut.edu.comparch.qtrvsim#4 (comment)

@Arielfoever
Copy link
Contributor

Arielfoever commented Jan 26, 2024 •
edited
Loading

Sure, it's building again. flathub/cz.cvut.edu.comparch.qtrvsim#4 (comment)

emmm I think it's a bug inside code. Rebuild this can't fix bug on Windows.

I think it is connected with #73

@jdupak
Copy link
Collaborator

jdupak commented Jan 26, 2024 via email

@jdupak jdupak self-assigned this Jan 27, 2024
@jdupak jdupak added the bug Something isn't working label Jan 27, 2024
@jdupak jdupak mentioned this issue Jan 27, 2024
Merged
@Arielfoever
Copy link
Contributor

Arielfoever commented Jan 28, 2024 •
edited
Loading

Hi gods,

The file comes from action https://github.com/cvut/qtrvsim/actions/runs/7679651824 still cause troubles.

I tested target-Windows-qt5.12.9 and it crashes many times.

Here's the log.

[DEBUG] gui.coreview:   Calling full update of 9BoolValue...
[DEBUG] gui.coreview:   Calling full update of 10DebugValue...
[DEBUG] gui.coreview:   Calling full update of 8RegValue...
[DEBUG] gui.coreview:   Calling full update of 10RegIdValue...
[DEBUG] gui.coreview:   Calling full update of 7PCValue...
[DEBUG] gui.coreview:   Calling full update of 14MultiTextValue...
[DEBUG] gui.coreview:   Calling full update of 16InstructionValue...
[DEBUG] gui.coreview:   Calling full update of 11MultiplexerIbE...
[DEBUG] gui.coreview:   Calling full update of 11MultiplexerIjE...
[FATAL ERROR]   ASSERT: "last >= first" in file itemmodels\qabstractitemmodel.cpp, line 2786

text.log

I'd say that my own build on my Windows 10 works fine. So that might be some bug inside CI.

@jdupak
Copy link
Collaborator

jdupak commented Jan 28, 2024 via email

@Arielfoever
Copy link
Contributor

Hi, do you mean actual crashes (application window disappears) or just the text in console? I am asking, bacause I cannot see any problem in the log file you posted. There is only (very detailed) information about execution, which is enabled only in debug builds. Everything not prefixed error or warning is fine.
…
On Sun, 28 Jan 2024, at 08:03, Ariel Xiong wrote: Hi gods, The file comes from action https://github.com/cvut/qtrvsim/actions/runs/7679651824 still cause troubles. I tested target-Windows-qt5.12.9 and it crashes many times. Here's the log. text.log https://github.com/cvut/qtrvsim/files/14075241/text.log I'd say that my own build on my Windows 10 works fine. So that might be some bug inside CI. — Reply to this email directly, view it on GitHub <#95 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFNB76DX3OAGE6BVVEI2R5DYQXZ3RAVCNFSM6AAAAABBQLURISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJTGQ4DAMBRGA. You are receiving this because you modified the open/close state.Message ID: @.***>

actual crashes (application window disappears)

@jdupak
Copy link
Collaborator

jdupak commented Feb 12, 2024

[FATAL ERROR] ASSERT: "last >= first" in file itemmodels\qabstractitemmodel.cpp, line 2786

@jdupak jdupak reopened this Feb 12, 2024
@jdupak jdupak mentioned this issue Feb 15, 2024
Merged
@jdupak
Copy link
Collaborator

jdupak commented Feb 15, 2024

@ArielHeleneto Oh, my apologies. You identified the issue correctly. I somehow missed the assert in your log. I am blind. Anyway should be fixed now. Tested on windows10.

Can you confirm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdupak jdupak

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GUI: fix crash when no tab is selected cvut/qtrvsim
GUI: fix crashes cvut/qtrvsim
3 participants
@okias @jdupak @Arielfoever