Qt6 #11
Merged
Qt6 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ported from QtMips by Jakub Dupak the exact changes are: * Assigning an int to QChar fails to compile due to type ambiguity. Changed occurences to either assign uchar or to use the default constructor. * QLineF::intersect replaced by QLineF::intersects * QTableView::viewOptions replaced by QTableView::initViewItemOption with a different interface - covered by preprocessor #if check * QFontMetrics::width replaced by QFontMetrics::horizontalAdvance * QFileDialog::setFileMode(QFileDialog::DirectoryOnly) replaced by QFileDialog::setFileMode(QFileDialog::Directory) and QFileDialog::setOption(QFileDialog::ShowDirsOnly, true) * QLayout::margin replaced by QLayout::getContentsMargins * Multiple calls to QString(int) replaced by QString::number(int) (I belive this was a bug in the original implementation and was uncovered thanks to the update) - This is probably the same problem as the one that popped up in the first change (QChar), not sure why it didn't complain sooner * There is a problem with Offset type not being the same size as size_t on macos, so a static_cast<size_t>(Offset) was added to fix the warning
…older. Ported from QtMips by Jakub Dupak. Signed-off-by: Pavel Pisa <pisa@cmp.felk.cvut.cz>
Ported from QtMips by Jakub Dupak. + horizontalAdvance polyfill Tested for qt5.9.5 and qt6.2.1 on linux-gcc64.
Ported from QtMips by Jakub Dupak.
Ported from QtMips by Jakub Dupak.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3