Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport the removal of PATCHES.txt to 1.x branch #258

Closed
donquixote opened this issue Mar 15, 2019 · 5 comments
Closed

Backport the removal of PATCHES.txt to 1.x branch #258

donquixote opened this issue Mar 15, 2019 · 5 comments

Comments

@donquixote
Copy link

In issue #140 / PR #213, the patch report generation (PATCHES.txt) was removed for the 2.x branch.
A release in this new branch has not happened yet.

I am going to provide a PR that backports this change to the 1.x branch.

@donquixote
Copy link
Author

The two commits from #213 will be squashed in the backported PR.

donquixote pushed a commit to donquixote/composer-patches that referenced this issue Mar 15, 2019
This is a backport of pull request cweagans#213 for issue cweagans#140.
The two commits from cweagans#213 have been squashed into one.
@alisonjo315
Copy link

I applied the change with a PR patch from #259 -- works great, I see no side effects! (Tested on a Drupal 8 project, with a patch to Drupal core.)

(Side note: I lol'ed when a "PATCHES.txt" file was created in vendor/cweagans/composer-patches 😁 -- not a bug at all, obviously, just a funny moment!)

@cweagans
Copy link
Owner

I'm okay with this, but can it be behind a config flag? I know of at least one user that relies on this and I don't want to break their workflow. Definitely okay with this being an opt-out thing though.

@awd-studio
Copy link

Hey! Would you mind? I made a PR for this.

cweagans added a commit that referenced this issue Jan 18, 2021
#258 Added a flag to skip reporting on applied patches
@cweagans
Copy link
Owner

cweagans commented Feb 7, 2023

There is now a config flag for this in 1.x. main doesn't have this functionality at all.

@cweagans cweagans closed this as completed Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants