Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove patch report generation #213

Merged
merged 2 commits into from
Jun 3, 2018
Merged

Remove patch report generation #213

merged 2 commits into from
Jun 3, 2018

Conversation

cweagans
Copy link
Owner

@cweagans cweagans commented Jun 3, 2018

I'm removing patch report generation and it's related config option because it's not necessary. Because the plugin will dispatch events before and after applying each patch, it's possible to generate this in a separate plugin if that's desired.

I also plan to add a composer patch-list command (which optionally accepts a package name as an argument) so that users will be able to see which patches are applied.

#140 also points out that PATCHES.txt might be a minor security risk in some cases, so it's better to just leave this out of the plugin entirely.

@coveralls
Copy link

coveralls commented Jun 3, 2018

Coverage Status

Coverage increased (+1.4%) to 33.209% when pulling 317198e on remove-patch-reports into f17c40d on master.

@cweagans cweagans merged commit b0dc9cd into master Jun 3, 2018
@cweagans cweagans deleted the remove-patch-reports branch June 3, 2018 22:10
donquixote pushed a commit to donquixote/composer-patches that referenced this pull request Mar 15, 2019
This is a backport of pull request cweagans#213 for issue cweagans#140.
The two commits from cweagans#213 have been squashed into one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants