authn-jwt - move cache binding point #2447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
app/domain/authentication/authn_jwt/signing_key/fetch_provider_uri_signing_key.rb
Outdated
Show resolved
Hide resolved
app/domain/authentication/authn_jwt/signing_key/fetch_jwks_uri_signing_key.rb
Outdated
Show resolved
Hide resolved
app/domain/authentication/authn_jwt/signing_key/fetch_jwks_uri_signing_key.rb
Outdated
Show resolved
Hide resolved
app/domain/authentication/authn_jwt/signing_key/fetch_provider_uri_signing_key.rb
Outdated
Show resolved
Hide resolved
app/domain/authentication/authn_jwt/signing_key/fetch_provider_uri_signing_key.rb
Show resolved
Hide resolved
sashaCher
force-pushed
the
authn-jwt-move-cache-layer
branch
from
d7d47dd
to
63877b5
Compare
tzheleznyak
reviewed
Dec 20, 2021
spec/app/domain/authentication/authn-jwt/signing_key/fetch_jwks_signing_key_spec.rb
Outdated
Show resolved
Hide resolved
tzheleznyak
reviewed
Dec 20, 2021
spec/app/domain/authentication/authn-jwt/signing_key/fetch_provider_uri_signing_key_spec.rb
Outdated
Show resolved
Hide resolved
benoaviram
reviewed
Dec 20, 2021
sashaCher
force-pushed
the
authn-jwt-move-cache-layer
branch
3 times, most recently
from
a90b49d
to
cad646e
Compare
tzheleznyak
reviewed
Dec 27, 2021
app/domain/authentication/authn_jwt/signing_key/fetch_provider_uri_signing_key.rb
Outdated
Show resolved
Hide resolved
sashaCher
force-pushed
the
authn-jwt-move-cache-layer
branch
2 times, most recently
from
8238730
to
14f0dc8
Compare
sashaCher
force-pushed
the
authn-jwt-move-cache-layer
branch
from
d7892b5
to
73672e2
Compare
| refresh: force_read, | ||
| cache_key: signing_key_provider.signing_key_uri, | ||
| signing_key_provider: signing_key_provider | ||
| def fetch_signing_key(force_fetch: false) |
There was a problem hiding this comment.
Authentication::AuthnJwt::ValidateAndDecode#fetch_signing_key has boolean parameter 'force_fetch'
|
Code Climate has analyzed commit 73672e2 and detected 3 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 90.9% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desired Outcome
Code is ready to have a Signing key fetcher class that does not require cashing.
Implemented Changes
Reactor code area around
Fetch*SigningKeyclasses and caching signing keys.More details can be found in in the design document (PR #2437)
Connected Issue/Story
ONYX-15138
Definition of Done
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
READMEs) were updated in this PRBehavior
Security