-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs for implicit/naked tasks #207
Conversation
Formerly naked tasks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, would suggest dropping the old "dummy task" and "naked task" terminology.
Implicit Tasks | ||
-------------- | ||
|
||
An :term:`implicit task` appears in the workflow graph but has no | ||
explicit runtime configuration section. Such tasks automatically | ||
inherit the default "dummy task" configuration from the root |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
inherit the default "dummy task" configuration from the root | |
inherit the default configuration from the root |
src/glossary.rst
Outdated
@@ -412,6 +412,29 @@ Glossary | |||
* :term:`job` | |||
* :term:`qualifier` | |||
|
|||
implicit task | |||
naked task |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
naked task |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about changing the first line to "Implicit tasks (previously known as naked tasks)..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could do, however, the terminology before was a mixture of, dummy
(incorrect), naked
(strange) and naked-dummy
(really strange and somewhat suggestive).
This comment has been minimized.
This comment has been minimized.
The only issue is that, as I understand it, a task can be non-implicit but still be a dummy task (e.g. if it has an empty but explicit section under |
I think we can probably get away without having a term for that, I'm not sure this is a concept we use often enough is it? There isn't really such a thing as a dummy task in Cylc. You can have a task which has not been configured to do anything in particular, however, that task will still run. Also all tasks inherit from From memory I think there is one legit use in the suite design guide where we advise inserting "dummy" tasks between large families to reduce the number of edges between them:
Perhaps in that section we could call it a "blank task" or something like that, however, since SoD we may be able to just remove this section alltogether. |
If you run a workflow in "dummy mode", does that mean it treats every task as having |
Ach, not quite, dummy mode is a bit icky, it is actually sets I would expect it to unset everything that you had defined (besides the Here's the code: The closest thing to a "dummy" i.e. a "bare" task (one with no config) occurs when you run the flow in I think we were trying to kill dummy mode but there was some use case left over, trying to remember. There's some note of it here - https://github.com/cylc/cylc-admin/blob/765e182557f6a7b702432cdae36b97f0a4c60b79/docs/feb2020-workshop-notes.md#wednesday (Dummy and dummy-local would probably map better onto sleep and sleep-local). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @MetRonnie
Companion to cylc/cylc-flow#4109