Fail by default if implicit/naked tasks present #4109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename naked -> implicit tasks - Add "allow implicit tasks" setting to flow.cylc
oliver-sanders
approved these changes
Mar 5, 2021
|
(All functional test batches failing). |
|
😫 I think we can call this "tests pass"
|
|
Looking at the timestamps the last updated as 15 minutes before the timeout so this isn't just a matter of an over-zealous timeout: This is the result of I'll run this branch through my MacOS setup just incase... ...tests/f/jinja2/ tests/f/restart/ all pass for me Rerunning actions to see if this is repeatable on actions... |
|
It's passing 🎉 (apart from a seemingly spurious pair of codecov checks) |
wxtim
added a commit
to wxtim/cylc
that referenced
this pull request
Mar 12, 2021
* 'master' of https://github.com/cylc/cylc: Fix a few typos (cylc#4122) data_store: remove prparing as a job state Fail by default if implicit/naked tasks present (cylc#4109)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes close #3866
Implicit tasks (task without an (empty) section in
flow.cylc[runtime]) are now disallowed by default, and will raise an error on validation.Added a setting
flow.cylc[scheduler]allow implicit tasksto allow them.Also removed the
--strictoption fromcylc validate, as it no longer does anything.Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.