Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

portability: patch mac os dns issues #262

Merged
merged 1 commit into from
Jul 15, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions src/installation.rst
Original file line number Diff line number Diff line change
Expand Up @@ -99,29 +99,6 @@ your ``$PATH``, follow the instructions in the ``brew install`` output.
``bash``). You do not need to change this but be aware that Cylc uses
``bash`` which has a subtly different syntax.

.. warning::

.. TODO - Get rid of this!!!!!!!!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 ✔️ done!

Cylc currently has DNS issues with the latest versions of Mac OS, to get
around them the following diff must be made to the installed source code:

.. code-block:: diff
diff --git a/cylc/flow/hostuserutil.py b/cylc/flow/hostuserutil.py
index 1b0bfc37d..73d5c9f98 100644
--- a/cylc/flow/hostuserutil.py
+++ b/cylc/flow/hostuserutil.py
@@ -113,7 +113,7 @@ class HostUtil(object):
"""Return the extended info of the current host."""
if target not in self._host_exs:
if target is None:
- target = socket.getfqdn()
+ target = socket.gethostname()
try:
self._host_exs[target] = socket.gethostbyname_ex(target)
except IOError as exc:
.. warning::

For Mac OS Versions 10.15.0 (Catalina) and higher SSH is disabled by
Expand Down