portability: patch mac os dns issues #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
kinow
approved these changes
Jul 12, 2021
There was a problem hiding this comment.
Looks good. The CI error is not related I think
2021-07-09T09:14:07Z ERROR - Workflow shutting down - AUTOMATIC(ON-TASK-FAILURE)
2021-07-09T09:14:07Z WARNING - Partially satisfied prerequisites left over:
consolidate_observations.20210709T0800Z is waiting on:
* get_observations_heathrow.20210709T0800Z succeeded
2021-07-09T09:14:07Z WARNING - Orphaned task jobs:
* get_rainfall.20210709T0800Z (running)
2021-07-09T09:14:08Z INFO - DONE
Error: Process completed with exit code 1.
| @@ -99,29 +99,6 @@ your ``$PATH``, follow the instructions in the ``brew install`` output. | |||
| ``bash``). You do not need to change this but be aware that Cylc uses | |||
| ``bash`` which has a subtly different syntax. | |||
|
|
|||
| .. warning:: | |||
|
|
|||
| .. TODO - Get rid of this!!!!!!!! | |||
|
(not sure whether we can merge it now, or if we need to wait for the sibling PR; if it's OK, feel free to press merge pull request or just confirm and I'll do it later 👍 thanks!) |
|
Should wait until the other PR is merged, thanks for reviewing. |
|
sibling PR merged, rebased, test passing (ignore tut workflow for now), merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sibling: cylc/cylc-flow#4296