portability: patch mac os dns issues #4296
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2689
downstream siblings:
Ok, I've finally given in and patched the DNS logic for Mac OS.
I started a branch overhauling
cylc.flow.hostuserutil
by making the contained logic completely configurable, however, it turns out to be messier than expected and we don't presently have the time to go down that road - https://github.com/oliver-sanders/cylc-flow/tree/dnsSo, simple solution, patch the Cylc logic to handle this strange python-socket binding behaviour and move on.
Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.setup.py
andconda-environment.yml
.