Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

portability: patch mac os dns issues #4296

Merged
merged 1 commit into from
Jul 13, 2021
Merged

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Jul 9, 2021

closes #2689
downstream siblings:

Ok, I've finally given in and patched the DNS logic for Mac OS.

I started a branch overhauling cylc.flow.hostuserutil by making the contained logic completely configurable, however, it turns out to be messier than expected and we don't presently have the time to go down that road - https://github.com/oliver-sanders/cylc-flow/tree/dns

So, simple solution, patch the Cylc logic to handle this strange python-socket binding behaviour and move on.

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.py and
    conda-environment.yml.
  • Already covered by existing tests.
  • Appropriate change log entry included.
  • (master branch) I have opened a documentation PR at portability: patch mac os dns issues cylc-doc#262

@oliver-sanders oliver-sanders added this to the cylc-8.0b2 milestone Jul 9, 2021
@oliver-sanders oliver-sanders self-assigned this Jul 9, 2021
conda-environment.yml Outdated Show resolved Hide resolved
Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new code is executed only on macos and the logic makes sense. Great comments, CI green, LGTM 🎉 thanks!

@oliver-sanders oliver-sanders changed the title portability: path mac os dns issues portability: patch mac os dns issues Jul 12, 2021
@oliver-sanders oliver-sanders requested review from wxtim and removed request for hjoliver July 13, 2021 13:22
Copy link
Member

@wxtim wxtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Looks sane
  • GHA tests passing
  • Played with it on a Mac VM on my PC.

@wxtim wxtim merged commit 442e505 into cylc:master Jul 13, 2021
@oliver-sanders oliver-sanders deleted the 2689 branch July 14, 2021 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Examples not running under OSX
3 participants