-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
companion to https://github.com/cylc/cylc-flow/pull/4455 #305
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but did you miss 3 instances?
┌──────( cylc-doc on master via v3.9.1 (venv)
└o git grep CYLC_WORKFLOW_NAME | wc -l
21
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we might want to have entries for workflow name and workflow ID in the glossary
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
06f72b1
to
202e8da
Compare
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Doc change for cylc/cylc-flow#4455
#304 Required before this can be merged