Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

companion to https://github.com/cylc/cylc-flow/pull/4455 #305

Merged
merged 4 commits into from
Oct 19, 2021

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Oct 7, 2021

Doc change for cylc/cylc-flow#4455

#304 Required before this can be merged

Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but did you miss 3 instances?

┌──────( cylc-doc on  master via  v3.9.1 (venv)
└o git grep CYLC_WORKFLOW_NAME | wc -l
21

Copy link
Member

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we might want to have entries for workflow name and workflow ID in the glossary

@wxtim wxtim requested review from MetRonnie and hjoliver October 11, 2021 07:11
src/glossary.rst Outdated Show resolved Hide resolved
src/glossary.rst Outdated Show resolved Hide resolved
src/glossary.rst Show resolved Hide resolved
src/glossary.rst Outdated Show resolved Hide resolved
src/glossary.rst Outdated Show resolved Hide resolved
@MetRonnie MetRonnie mentioned this pull request Oct 11, 2021
@wxtim wxtim requested a review from MetRonnie October 14, 2021 15:30
src/glossary.rst Outdated Show resolved Hide resolved
src/glossary.rst Outdated Show resolved Hide resolved
src/glossary.rst Outdated Show resolved Hide resolved
src/glossary.rst Outdated Show resolved Hide resolved
@wxtim wxtim requested a review from MetRonnie October 15, 2021 07:27
wxtim and others added 3 commits October 15, 2021 08:31
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
@wxtim wxtim force-pushed the companion.to.cylc.flow.4455 branch from 06f72b1 to 202e8da Compare October 15, 2021 07:34
src/glossary.rst Outdated Show resolved Hide resolved
src/glossary.rst Outdated Show resolved Hide resolved
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
@wxtim wxtim requested a review from MetRonnie October 18, 2021 12:13
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hjoliver hjoliver merged commit 4c12537 into cylc:master Oct 19, 2021
@wxtim wxtim deleted the companion.to.cylc.flow.4455 branch October 20, 2021 07:31
@MetRonnie MetRonnie modified the milestones: 8.0rc1, 8.0b3 Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants