Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing #307

Closed
wants to merge 3 commits into from
Closed

Testing #307

wants to merge 3 commits into from

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Oct 11, 2021 •
edited
Loading

(It's still not passing, but the change to fix the other break is in metronnie 's PR #304 - Somehow a :ref:backCompat (added in Ronnie's PR) has snuck into cylc-flow master...

@wxtim wxtim marked this pull request as draft October 11, 2021 08:09
@wxtim wxtim requested a review from MetRonnie October 11, 2021 08:24
@wxtim wxtim marked this pull request as ready for review October 11, 2021 08:24
@wxtim wxtim self-assigned this Oct 11, 2021
@wxtim wxtim added this to the 8.0.0 milestone Oct 11, 2021
@MetRonnie
Copy link
Member

MetRonnie commented Oct 11, 2021 •
edited
Loading

@wxtim I would merge this but looks like it contains leakage from #305. If it's alright I'll push to master a hotfix commit node version -> 16 for test.yml to get the tests working

@MetRonnie MetRonnie closed this Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MetRonnie MetRonnie MetRonnie left review comments

Assignees

@wxtim wxtim

Labels
None yet
Projects
None yet
Milestone
8.0rc1
Development

Successfully merging this pull request may close these issues.
2 participants
@wxtim @MetRonnie