Remove cylc.flags.iflag #2871
Merged
Remove cylc.flags.iflag #2871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove a global state variable. * Record same info using attr variables in scheduler and tasks. * Update to task summary message always trigger a summary update.
kinow
approved these changes
Nov 20, 2018
hjoliver
approved these changes
Nov 21, 2018
|
(also checked that the same number of state summary updates occurs on this branch as on master). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a global state variable.
.summary['latest_message']now correctly triggers a summary update.Inspired by our recent discussion (#2865), I thought I'll have a go at migrating the global
cylc.flags.iflagvariable to become local object attributes. The solution is not perfect, because I am no longer able to use a single variable (without making this change a lot bigger), but it is a workable solution without compromising the current logic.